[PATCH 4.2.y-ckt 161/305] um: Fix get_signal() usage

From	Kamal Mostafa <kamal@canonical.com>
Newsgroups	linux.kernel
Subject	[PATCH 4.2.y-ckt 161/305] um: Fix get_signal() usage
Date	2016-01-16 01:50 +0100
Message-ID	<qRne3-5ix-47@gated-at.bofh.it> (permalink)
References	<qRmBj-507-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

4.2.8-ckt2 -stable review patch.  If anyone has any objections, please let me know.

---8<------------------------------------------------------------

From: Richard Weinberger <richard@nod.at>

commit db2f24dc240856fb1d78005307f1523b7b3c121b upstream.

If get_signal() returns us a signal to post
we must not call it again, otherwise the already
posted signal will be overridden.
Before commit a610d6e672d this was the case as we stopped
the while after a successful handle_signal().

Fixes: a610d6e672d ("pull clearing RESTORE_SIGMASK into block_sigmask()")
Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
---
 arch/um/kernel/signal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/um/kernel/signal.c b/arch/um/kernel/signal.c
index 4f60e4a..50b6e9f 100644
--- a/arch/um/kernel/signal.c
+++ b/arch/um/kernel/signal.c
@@ -69,7 +69,7 @@ static int kern_do_signal(struct pt_regs *regs)
 	struct ksignal ksig;
 	int handled_sig = 0;
 
-	while (get_signal(&ksig)) {
+	if (get_signal(&ksig)) {
 		handled_sig = 1;
 		/* Whee!  Actually deliver the signal.  */
 		handle_signal(&ksig, regs);
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 4.2.y-ckt 161/305] um: Fix get_signal() usage Kamal Mostafa <kamal@canonical.com> - 2016-01-16 01:50 +0100
  Re: [PATCH 4.2.y-ckt 161/305] um: Fix get_signal() usage Richard Weinberger <richard@nod.at> - 2016-01-16 21:50 +0100
    Re: [PATCH 4.2.y-ckt 161/305] um: Fix get_signal() usage Kamal Mostafa <kamal@canonical.com> - 2016-01-19 17:10 +0100

csiph-web