Re: [PATCH] drm/panel: simple: Add support for Sharp LQ101K1LY04

From	Joshua Clayton <stillcompiling@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drm/panel: simple: Add support for Sharp LQ101K1LY04
Date	2016-01-12 21:50 +0100
Message-ID	<qQe38-69u-25@gated-at.bofh.it> (permalink)
References	<qQ9Gb-3id-25@gated-at.bofh.it> <qQckG-4Yo-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Lucas,
Thanks for the review. 

On Tue, 12 Jan 2016 19:45:30 +0100
Lucas Stach <dev@lynxeye.de> wrote:

> >  drivers/gpu/drm/panel/panel-simple.c | 26
> > ++++++++++++++++++++++++++
> 
> Missing documentation for the DT binding.
>

Thanks, will add. 

...

> > +	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA,
> > +};
> > +
> This hunk isn't added at the correct place. Please keep the
> alphabetical sorting.
OK. Makes sense. I'll reorder these.
> 
> >  static const struct display_timing hannstar_hsd070pww1_timing = {
> >  	.pixelclock = { 64300000, 71100000, 82000000 },
> >  	.hactive = { 1280, 1280, 1280 },
> > @@ -1146,6 +1169,9 @@ static const struct of_device_id
> > platform_of_match[] = {
> >  		.compatible = "hannstar,hsd070pww1",
> >  		.data = &hannstar_hsd070pww1,
> >  	}, {
> > +		.compatible = "sharp,lq101k1ly04",
> > +		.data = &sharp_lq101k1ly04,
> > +	}, {
> 
> Wrong insertion place again.
OK. Will reorder alphabetically also. 

Joshua

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] drm/panel: simple: Add support for Sharp LQ101K1LY04 Joshua Clayton <stillcompiling@gmail.com> - 2016-01-12 17:10 +0100
  Re: [PATCH] drm/panel: simple: Add support for Sharp LQ101K1LY04 Joshua Clayton <stillcompiling@gmail.com> - 2016-01-12 18:50 +0100
  Re: [PATCH] drm/panel: simple: Add support for Sharp LQ101K1LY04 Lucas Stach <dev@lynxeye.de> - 2016-01-12 20:00 +0100
    Re: [PATCH] drm/panel: simple: Add support for Sharp LQ101K1LY04 Joshua Clayton <stillcompiling@gmail.com> - 2016-01-12 21:50 +0100

csiph-web