[PATCH 1/4] mailbox: mailbox-test: Use more consistent format for calling copy_from_user()

From	Lee Jones <lee.jones@linaro.org>
Newsgroups	linux.kernel
Subject	[PATCH 1/4] mailbox: mailbox-test: Use more consistent format for calling copy_from_user()
Date	2016-01-14 08:20 +0100
Message-ID	<qQKml-3Em-1@gated-at.bofh.it> (permalink)
References	<qQKml-3Em-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

While we're at it, ensure copy-to location is NULL'ed in the error path.

Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/mailbox/mailbox-test.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mailbox/mailbox-test.c b/drivers/mailbox/mailbox-test.c
index 684ae17..7d9b915 100644
--- a/drivers/mailbox/mailbox-test.c
+++ b/drivers/mailbox/mailbox-test.c
@@ -63,9 +63,9 @@ static ssize_t mbox_test_signal_write(struct file *filp,
 	if (!tdev->signal)
 		return -ENOMEM;
 
-	ret = copy_from_user(tdev->signal, userbuf, count);
-	if (ret) {
+	if (copy_from_user(tdev->signal, userbuf, count)) {
 		kfree(tdev->signal);
+		tdev->signal = NULL;
 		return -EFAULT;
 	}
 
-- 
1.9.1

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 1/4] mailbox: mailbox-test: Use more consistent format for calling copy_from_user() Lee Jones <lee.jones@linaro.org> - 2016-01-14 08:20 +0100

csiph-web