Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1307108

Re: [STABLE] kernel oops which can be fixed by peterz's patches

Show all headers | View raw

On Tue, Jan 05, 2016 at 10:14:44AM +0100, Peter Zijlstra wrote:
> On Tue, Jan 05, 2016 at 05:52:11PM +0900, Byungchul Park wrote:
> > 
> > Upstream commits to be applied
> > ==============================
> > 
> > e3fca9e: sched: Replace post_schedule with a balance callback list
> > 4c9a4bc: sched: Allow balance callbacks for check_class_changed()
> > 8046d68: sched,rt: Remove return value from pull_rt_task()
> > fd7a4be: sched, rt: Convert switched_{from, to}_rt() / prio_changed_rt() to balance callbacks
> > 0ea60c2: sched,dl: Remove return value from pull_dl_task()
> > 9916e21: sched, dl: Convert switched_{from, to}_dl() / prio_changed_dl() to balance callbacks
> > 
> > The reason why these should be applied
> > ======================================
> > 
> > Our products developed using 3.16 kernel, faced a kernel oops which can
> > be fixed with above upstreamed patches. The oops is caused by "Unable
> > to handle kernel NULL pointer dereference at virtual address 000000xx"
> > in the call path,
> > 
> > __sched_setscheduler()
> > 	check_class_changed()
> > 		switched_to_fair()
> > 			check_preempt_curr()
> > 				check_preempt_wakeup()
> > 					find_matching_se()
> > 						is_same_group()
> > 
> > by "if (se->cfs_rq == pse->cfs_rq) // se, pse == NULL" condition.
> 
> So the reason I didn't mark them for stable is that they were non
> trivial, however they've been in for a while now and nothing broke, so I
> suppose backporting them isn't a problem.

Do you think the backporting can have some potential problems? I
checked if it worked well on my machine. Do you think it need more
tests to verify its stability?

> 
> > How to apply it
> > ===============
> > 
> > For stable 4.2.8+:
> > 	N/A (already applied)
> > 
> > For longterm 4.1.15:
> > 	Cherry-picking the upsteam commits works with a trivial conflict.
> > 
> > For longterm 3.18.25:
> > 	Refer to the backported patches in this thread.
> > 
> > For longterm 3.14.58:
> > 	Refer to the backported patches in this thread. And applying
> > 	additional "6c3b4d4: sched: Clean up idle task SMP logic" commit
> > 	makes backporting the upstream commits much simpler. So my
> > 	backporting patches include the patch.
> > 
> > For longterm 2.6.32.69 ~ 3.12.51: Need to be backported. (I didn't)
> 
> No objection as long as you've actually tested things etc..
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[STABLE] kernel oops which can be fixed by peterz's patches Byungchul Park <byungchul.park@lge.com> - 2016-01-05 10:00 +0100
  [PATCH for v3.14.58 7/7] sched, dl: Convert switched_{from, to}_dl() / prio_changed_dl() to balance callbacks Byungchul Park <byungchul.park@lge.com> - 2016-01-05 10:20 +0100
  Re: [STABLE] kernel oops which can be fixed by peterz's patches Peter Zijlstra <peterz@infradead.org> - 2016-01-05 10:20 +0100
    Re: [STABLE] kernel oops which can be fixed by peterz's patches Byungchul Park <byungchul.park@lge.com> - 2016-01-12 09:50 +0100
    Re: [STABLE] kernel oops which can be fixed by peterz's patches Willy Tarreau <w@1wt.eu> - 2016-01-12 11:30 +0100
  [PATCH for v3.14.58 6/7] sched,dl: Remove return value from pull_dl_task() Byungchul Park <byungchul.park@lge.com> - 2016-01-05 10:20 +0100
  [PATCH for v3.14.58 1/7] sched: Clean up idle task SMP logic Byungchul Park <byungchul.park@lge.com> - 2016-01-05 10:20 +0100
    [PATCH for v3.14.58 4/7] sched,rt: Remove return value from pull_rt_task() Byungchul Park <byungchul.park@lge.com> - 2016-01-05 10:20 +0100
    [PATCH for v3.14.58 2/7] sched: Replace post_schedule with a balance callback list Byungchul Park <byungchul.park@lge.com> - 2016-01-05 10:20 +0100
    [PATCH for v3.14.58 3/7] sched: Allow balance callbacks for check_class_changed() Byungchul Park <byungchul.park@lge.com> - 2016-01-05 10:20 +0100
    [PATCH for v3.14.58 5/7] sched, rt: Convert switched_{from, to}_rt() / prio_changed_rt() to balance callbacks Byungchul Park <byungchul.park@lge.com> - 2016-01-05 10:20 +0100
  [PATCH for v3.18.25 1/6] sched: Replace post_schedule with a balance callback list Byungchul Park <byungchul.park@lge.com> - 2016-01-05 10:30 +0100
    [PATCH for v3.18.25 3/6] sched,rt: Remove return value from pull_rt_task() Byungchul Park <byungchul.park@lge.com> - 2016-01-05 10:30 +0100
    [PATCH for v3.18.25 4/6] sched, rt: Convert switched_{from, to}_rt() / prio_changed_rt() to balance callbacks Byungchul Park <byungchul.park@lge.com> - 2016-01-05 10:30 +0100
    [PATCH for v3.18.25 6/6] sched, dl: Convert switched_{from, to}_dl() / prio_changed_dl() to balance callbacks Byungchul Park <byungchul.park@lge.com> - 2016-01-05 10:30 +0100
    [PATCH for v3.18.25 5/6] sched,dl: Remove return value from pull_dl_task() Byungchul Park <byungchul.park@lge.com> - 2016-01-05 10:30 +0100
    [PATCH for v3.18.25 2/6] sched: Allow balance callbacks for check_class_changed() Byungchul Park <byungchul.park@lge.com> - 2016-01-05 10:30 +0100

csiph-web