Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1307096
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: mfd-dm355evm_msp: One function call less in add_child() after error detection |
| Date | 2016-01-12 09:40 +0100 |
| Message-ID | <qQ2EG-6Ka-5@gated-at.bofh.it> (permalink) |
| References | <qEuGl-43C-5@gated-at.bofh.it> <qL2ci-X1-3@gated-at.bofh.it> <qPGb8-8fa-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
>> The platform_device_put() function was called in one case by the >> add_child() function during error handling even if the passed >> variable "pdev" contained a null pointer. >> >> Implementation details could be improved by the adjustment of jump targets >> according to the Linux coding style convention. >> >> This issue was detected by using the Coccinelle software. >> >> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> >> --- >> drivers/mfd/dm355evm_msp.c | 21 ++++++++++----------- >> 1 file changed, 10 insertions(+), 11 deletions(-) > > Same comments as before. To which comments do you refer here? Are you interested in any further clarification of open issues? Regards, Markus
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH] mfd-dm355evm_msp: One function call less in add_child() after error detection Lee Jones <lee.jones@linaro.org> - 2016-01-11 09:40 +0100
Re: mfd-dm355evm_msp: One function call less in add_child() after error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-12 09:40 +0100
Re: mfd-dm355evm_msp: One function call less in add_child() after error detection Lee Jones <lee.jones@linaro.org> - 2016-01-12 10:10 +0100
Re: mfd-dm355evm_msp: One function call less in add_child() after error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-12 12:50 +0100
Re: mfd-dm355evm_msp: One function call less in add_child() after error detection Lee Jones <lee.jones@linaro.org> - 2016-01-12 13:00 +0100
csiph-web