Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1305963

Re: [PATCH] ASoC: mediatek: Enable 33bit memory address to support 4GB DRAM

Show all headers | View raw

On Mon, 11 Jan 2016 09:00:50 +0100,
PC Liao wrote:
> 
> @@ -603,7 +606,10 @@ static int mtk_afe_dais_hw_params(struct snd_pcm_substream *substream,
>  	if (ret < 0)
>  		return ret;
>  
> -	memif->phys_buf_addr = substream->runtime->dma_addr;
> +	if (sizeof(dma_addr_t) > 4)
> +		msb_at_bit33 = (substream->runtime->dma_addr & 0x100000000) ? 1 : 0;

Better to put a proper suffix for the constant over 32bit.

Or use upper_32_bits().  Then sizeof() check can be omitted, as the
compiler should be smart enough to know it beforehand.


Takashi

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ASoC: mediatek: Enable 33bit memory address to support 4GB DRAM PC Liao <pc.liao@mediatek.com> - 2016-01-11 09:10 +0100
  Re: [PATCH] ASoC: mediatek: Enable 33bit memory address to support 4GB DRAM Takashi Iwai <tiwai@suse.de> - 2016-01-11 10:10 +0100
    Re: [PATCH] ASoC: mediatek: Enable 33bit memory address to support  4GB DRAM PC Liao <pc.liao@mediatek.com> - 2016-01-12 04:00 +0100
      Re: [PATCH] ASoC: mediatek: Enable 33bit memory address to support 4GB DRAM Takashi Iwai <tiwai@suse.de> - 2016-01-12 06:50 +0100

csiph-web