Re: [PATCH v2] thinkpad_acpi: Add support for keyboard backlight

From	Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] thinkpad_acpi: Add support for keyboard backlight
Date	2016-01-09 18:40 +0100
Message-ID	<qP5EB-k4-3@gated-at.bofh.it> (permalink)
References	<qJj7z-1O0-1@gated-at.bofh.it> <qLxpM-45O-17@gated-at.bofh.it> <qNjC4-8eg-43@gated-at.bofh.it> <qNjVo-8lm-9@gated-at.bofh.it> <qNkeL-8sV-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jan 4, 2016, at 18:40, Darren Hart wrote:
> On Mon, Jan 04, 2016 at 09:26:19PM +0100, Pali Rohár wrote:
> > On Monday 04 January 2016 21:04:25 Darren Hart wrote:
> > > On Wed, Dec 30, 2015 at 11:27:41PM +0100, Pali Rohár wrote:
> > > > This patch adds support for controlling keyboard backlight via
> > > > standard linux led class interface (::kbd_backlight). It uses ACPI
> > > > HKEY device with MLCG and MLCS methods.
> > > 
> > > Which laptops is this intended to support?
> > 
> > Thinkpad ??30 series and new which have backlight keyboard.
> 
> Thanks, we should include that in the commit message as well as the
> comments
> surrounding the driver section.
> 
> Henrique, are your concerns surrounding suspend/resume resolved?

Yes.

Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] thinkpad_acpi: Add support for keyboard backlight Darren Hart <dvhart@infradead.org> - 2016-01-04 21:10 +0100
  Re: [PATCH v2] thinkpad_acpi: Add support for keyboard backlight Pali Rohár <pali.rohar@gmail.com> - 2016-01-04 21:30 +0100
    Re: [PATCH v2] thinkpad_acpi: Add support for keyboard backlight Darren Hart <dvhart@infradead.org> - 2016-01-04 21:50 +0100
      Re: [PATCH v2] thinkpad_acpi: Add support for keyboard backlight Pali Rohár <pali.rohar@gmail.com> - 2016-01-04 22:00 +0100
        Re: [PATCH v2] thinkpad_acpi: Add support for keyboard backlight Darren Hart <dvhart@infradead.org> - 2016-01-04 22:50 +0100
      Re: [PATCH v2] thinkpad_acpi: Add support for keyboard backlight Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2016-01-09 18:40 +0100

csiph-web