Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1305126
| From | Andrew Lunn <andrew@lunn.ch> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] net: phy: Add support for SMSC LAN8740 PHY |
| Date | 2016-01-09 02:40 +0100 |
| Message-ID | <qOQFz-6Is-5@gated-at.bofh.it> (permalink) |
| References | <qOQ2S-6c6-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Jan 08, 2016 at 05:57:20PM -0700, Joshua Henderson wrote:
> LAN8740 has a different phy_id than LAN8710/LAN8720.
>
> Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com>
> ---
> drivers/net/phy/smsc.c | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c
> index dc2da87..34021a5 100644
> --- a/drivers/net/phy/smsc.c
> +++ b/drivers/net/phy/smsc.c
> @@ -264,6 +264,29 @@ static struct phy_driver smsc_phy_driver[] = {
> .resume = genphy_resume,
>
> .driver = { .owner = THIS_MODULE, }
> +}, {
> + .phy_id = 0x0007c110,
> + .phy_id_mask = 0xfffffff0,
> + .name = "SMSC LAN8740",
> +
> + .features = (PHY_BASIC_FEATURES | SUPPORTED_Pause
> + | SUPPORTED_Asym_Pause),
> + .flags = PHY_HAS_INTERRUPT | PHY_HAS_MAGICANEG,
> +
> + /* basic functions */
> + .config_aneg = genphy_config_aneg,
> + .read_status = lan87xx_read_status,
> + .config_init = smsc_phy_config_init,
> + .soft_reset = smsc_phy_reset,
> +
> + /* IRQ related */
> + .ack_interrupt = smsc_phy_ack_interrupt,
> + .config_intr = smsc_phy_config_intr,
> +
> + .suspend = genphy_suspend,
> + .resume = genphy_resume,
> +
> + .driver = { .owner = THIS_MODULE, }
> } };
Hi Joshua
You should remove this .driver line. The core sets it now.
Andrew
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] net: phy: Add support for SMSC LAN8740 PHY Joshua Henderson <joshua.henderson@microchip.com> - 2016-01-09 02:00 +0100
Re: [PATCH] net: phy: Add support for SMSC LAN8740 PHY Andrew Lunn <andrew@lunn.ch> - 2016-01-09 02:40 +0100
Re: [PATCH] net: phy: Add support for SMSC LAN8740 PHY Joshua Henderson <joshua.henderson@microchip.com> - 2016-01-09 12:50 +0100
csiph-web