Re: [PATCH v2 20/32] metag: define __smp_xxx

From	James Hogan <james.hogan@imgtec.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 20/32] metag: define __smp_xxx
Date	2016-01-04 17:10 +0100
Message-ID	<qNfRM-5IQ-3@gated-at.bofh.it> (permalink)
References	<qLQLL-8pu-3@gated-at.bofh.it> <qLQLL-8pu-13@gated-at.bofh.it> <qNdGi-48u-15@gated-at.bofh.it> <qNff4-5dA-25@gated-at.bofh.it> <qNfoK-5i3-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Jan 04, 2016 at 04:30:36PM +0100, Peter Zijlstra wrote:
> On Mon, Jan 04, 2016 at 03:25:58PM +0000, James Hogan wrote:
> > It is used along with the metag specific __global_lock1() (global
> > voluntary lock between hw threads) whenever a write is performed, and by
> > smp_mb/smp_rmb to try to catch other cases, but I've never been
> > confident this fixes every single corner case, since there could be
> > other places where multiple CPUs perform unsynchronised writes to the
> > same memory location, and expect cache not to become incoherent at that
> > location.
> 
> Ah, yuck, I thought blackfin was the only one attempting !coherent SMP.
> And yes, this is bound to break in lots of places in subtle ways. We
> very much assume cache coherency for SMP in generic code.

Well, its usually completely coherent, its just a bit dodgy in a
particular hardware corner case, which was pretty hard to hit, even
without these workarounds.

> 
> > It seemed to be sufficient to achieve stability however, and SMP on Meta
> > Linux never made it into a product anyway, since the other hw thread
> > tended to be used for RTOS stuff, so it didn't seem worth extending the
> > generic barrier API for it.
> 
> *phew*, should we take it out then, just to be sure nobody accidentally
> tries to use it then?

SMP support on this SoC you mean? I doubt it'll be a problem tbh, and
it'd work fine in QEMU when emulating this SoC, so I'd prefer to keep it
in.

Cheers
James

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 20/32] metag: define __smp_xxx Peter Zijlstra <peterz@infradead.org> - 2016-01-04 14:50 +0100
  Re: [PATCH v2 20/32] metag: define __smp_xxx James Hogan <james.hogan@imgtec.com> - 2016-01-04 16:30 +0100
    Re: [PATCH v2 20/32] metag: define __smp_xxx Peter Zijlstra <peterz@infradead.org> - 2016-01-04 16:40 +0100
      Re: [PATCH v2 20/32] metag: define __smp_xxx James Hogan <james.hogan@imgtec.com> - 2016-01-04 17:10 +0100

csiph-web