Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1300095

Re: [PATCH 1/8] mm: Add optional support for PUD-sized transparent hugepages

Show all headers | View raw

On Mon, Dec 28, 2015 at 12:05:51PM +0200, Kirill A. Shutemov wrote:
> On Thu, Dec 24, 2015 at 11:20:30AM -0500, Matthew Wilcox wrote:
> > diff --git a/include/linux/mm.h b/include/linux/mm.h
> > index 4bf3811..e14634f 100644
> > --- a/include/linux/mm.h
> > +++ b/include/linux/mm.h
> > @@ -1958,6 +1977,17 @@ static inline spinlock_t *pmd_lock(struct mm_struct *mm, pmd_t *pmd)
> >  	return ptl;
> >  }
> >  
> > +/*
> > + * No scalability reason to split PUD locks yet, but follow the same pattern
> > + * as the PMD locks to make it easier if we have to.
> > + */
> 
> I don't think it makes any good unless you convert all other places where
> we use page_table_lock to protect pud table (like __pud_alloc()) to the
> same API.
> I think this would deserve separate patch.

Sure, a separate patch to convert existing users of the PTL.  But I
don't think it does any harm to introduce the PUD version of the PMD API.
Maybe with a comment indicating that tere is significant work to be done
in converting existing users to this API?

> > diff --git a/mm/memory.c b/mm/memory.c
> > index 416b129..7328df0 100644
> > --- a/mm/memory.c
> > +++ b/mm/memory.c
> > @@ -1220,9 +1220,27 @@ static inline unsigned long zap_pud_range(struct mmu_gather *tlb,
> >  	pud = pud_offset(pgd, addr);
> >  	do {
> >  		next = pud_addr_end(addr, end);
> > +		if (pud_trans_huge(*pud) || pud_devmap(*pud)) {
> > +			if (next - addr != HPAGE_PUD_SIZE) {
> > +#ifdef CONFIG_DEBUG_VM
> 
> IS_ENABLED(CONFIG_DEBUG_VM) ?
> 
> > +				if (!rwsem_is_locked(&tlb->mm->mmap_sem)) {
> > +					pr_err("%s: mmap_sem is unlocked! addr=0x%lx end=0x%lx vma->vm_start=0x%lx vma->vm_end=0x%lx\n",
> > +						__func__, addr, end,
> > +						vma->vm_start,
> > +						vma->vm_end);
> 
> dump_vma(), I guess.

These two issues are copy-and-paste from the existing PMD code.  I'm happy
to update the PMD code to the new-and-improved way of doing things;
I'm just not keen to have the PMD and PUD code diverge unnecessarily.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/8] Support for transparent PUD pages Matthew Wilcox <matthew.r.wilcox@intel.com> - 2015-12-24 17:30 +0100
  [PATCH 4/8] x86: Add support for PUD-sized transparent hugepages Matthew Wilcox <matthew.r.wilcox@intel.com> - 2015-12-24 17:30 +0100
  [PATCH 1/8] mm: Add optional support for PUD-sized transparent hugepages Matthew Wilcox <matthew.r.wilcox@intel.com> - 2015-12-24 17:30 +0100
    Re: [PATCH 1/8] mm: Add optional support for PUD-sized transparent  hugepages "Kirill A. Shutemov" <kirill@shutemov.name> - 2015-12-28 11:10 +0100
      Re: [PATCH 1/8] mm: Add optional support for PUD-sized transparent  hugepages Matthew Wilcox <willy@linux.intel.com> - 2016-01-02 18:10 +0100
        Re: [PATCH 1/8] mm: Add optional support for PUD-sized transparent  hugepages "Kirill A. Shutemov" <kirill@shutemov.name> - 2016-01-04 21:40 +0100
    Re: [PATCH 1/8] mm: Add optional support for PUD-sized transparent  hugepages "Kirill A. Shutemov" <kirill@shutemov.name> - 2015-12-28 11:20 +0100
  [PATCH 3/8] procfs: Add support for PUDs to smaps, clear_refs and pagemap Matthew Wilcox <matthew.r.wilcox@intel.com> - 2015-12-24 17:30 +0100
  [PATCH 7/8] xfs: Support for transparent PUD pages Matthew Wilcox <matthew.r.wilcox@intel.com> - 2015-12-24 17:30 +0100
    Re: [PATCH 7/8] xfs: Support for transparent PUD pages Dave Chinner <david@fromorbit.com> - 2015-12-31 00:40 +0100
      Re: [PATCH 7/8] xfs: Support for transparent PUD pages Matthew Wilcox <willy@linux.intel.com> - 2016-01-02 17:50 +0100
        Re: [PATCH 7/8] xfs: Support for transparent PUD pages Dave Chinner <david@fromorbit.com> - 2016-01-03 21:40 +0100
          Re: [PATCH 7/8] xfs: Support for transparent PUD pages "Kirill A. Shutemov" <kirill@shutemov.name> - 2016-01-04 21:50 +0100
            Re: [PATCH 7/8] xfs: Support for transparent PUD pages Matthew Wilcox <willy@linux.intel.com> - 2016-01-04 23:10 +0100
  [PATCH 8/8] ext4: Transparent support for PUD-sized transparent huge pages Matthew Wilcox <matthew.r.wilcox@intel.com> - 2015-12-24 17:30 +0100
  [PATCH 5/8] dax: Support for transparent PUD pages Matthew Wilcox <matthew.r.wilcox@intel.com> - 2015-12-24 17:30 +0100

csiph-web