Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1299148

Re: [PATCH v3 0/4] Add online file check feature

Show all headers | View raw

On Fri, 25 Dec 2015 15:16:15 +0800 Gang He <ghe@suse.com> wrote:

> When there are errors in the ocfs2 filesystem,
> they are usually accompanied by the inode number which caused the error.
> This inode number would be the input to fixing the file.
> One of these options could be considered:
> A file in the sys filesytem which would accept inode numbers.
> This could be used to communication back what has to be fixed or is fixed.
> You could write:
> $# echo "<inode>" > /sys/fs/ocfs2/devname/filecheck/check
> or
> $# echo "<inode>" > /sys/fs/ocfs2/devname/filecheck/fix
> 
> Compare with second version, I re-design filecheck sysfs interfaces, there
> are three sysfs files(check, fix and set) under filecheck directory(see above),
> sysfs will accept only one argument <inode>. Second, I adjust some code in 
> ocfs2_filecheck_repair_inode_block() function according to upstream feedback,
> we cannot just add VALID_FL flag back as a inode block fix, then we will not 
> fix this field corruption currently until having a complete solution.
> Compare with first version, I use strncasecmp instead of double strncmp
> functions. Second, update the source file contribution vendor.

This feature should be documented, please.  That means all pseudo-file
locations, all inputs, all outputs, expected behaviour etc etc.  Enough
info so that our users can usefully and fully use this feature in the
minimum time.  Documentation/filesystems/ocfs2.txt is the place for that.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/4] Add online file check feature Gang He <ghe@suse.com> - 2015-12-25 08:20 +0100
  [PATCH v3 2/4] ocfs2: sysfile interfaces for online file check Gang He <ghe@suse.com> - 2015-12-25 08:20 +0100
  [PATCH v3 4/4] ocfs2: check/fix inode block for online file check Gang He <ghe@suse.com> - 2015-12-25 08:20 +0100
  Re: [PATCH v3 0/4] Add online file check feature Andrew Morton <akpm@linux-foundation.org> - 2015-12-29 22:50 +0100
    Re: [PATCH v3 0/4] Add online file check feature "Gang He" <ghe@suse.com> - 2015-12-30 04:10 +0100
      Re: [PATCH v3 0/4] Add online file check feature Andrew Morton <akpm@linux-foundation.org> - 2015-12-30 04:20 +0100

csiph-web