Re: [PATCH] MAINTAINERS: Add myself as a reviewer for the bq27xxx driver.

From	Sebastian Reichel <sre@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] MAINTAINERS: Add myself as a reviewer for the bq27xxx driver.
Date	2015-12-31 22:10 +0100
Message-ID	<qLSDT-17P-3@gated-at.bofh.it> (permalink)
References	<qLtPc-1Kb-7@gated-at.bofh.it> <qLQsq-82w-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On Thu, Dec 31, 2015 at 07:40:04PM +0100, Pali Rohár wrote:
> On Wednesday 30 December 2015 19:35:41 Andrew F. Davis wrote:
> > Signed-off-by: Andrew F. Davis <afd@ti.com>
> > ---
> >  MAINTAINERS | 10 ++++++++--
> >  1 file changed, 8 insertions(+), 2 deletions(-)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 44666b1..046d001 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -7605,10 +7605,8 @@ NOKIA N900 POWER SUPPLY DRIVERS
> >  M:	Pali Rohár <pali.rohar@gmail.com>
> >  S:	Maintained
> >  F:	include/linux/power/bq2415x_charger.h
> > -F:	include/linux/power/bq27xxx_battery.h
> >  F:	include/linux/power/isp1704_charger.h
> >  F:	drivers/power/bq2415x_charger.c
> > -F:	drivers/power/bq27xxx_battery.c
> >  F:	drivers/power/isp1704_charger.c
> >  F:	drivers/power/rx51_battery.c
> 
> I think it is not needed to remove files from this section as here are 
> all power supply files for Nokia N900.
>
> > @@ -10710,6 +10708,14 @@ L:	linux-omap@vger.kernel.org
> >  S:	Maintained
> >  F:	drivers/thermal/ti-soc-thermal/
> > 
> > +TI BQ27XXX POWER SUPPLY DRIVER
> > +M:	Pali Rohár <pali.rohar@gmail.com>
> > +R:	Andrew F. Davis <afd@ti.com>
> > +S:	Maintained
> > +F:	include/linux/power/bq27xxx_battery.h
> > +F:	drivers/power/bq27xxx_battery.c
> > +F:	drivers/power/bq27xxx_battery_i2c.c

I think it would make sense to have it like this:

NOKIA N900 POWER SUPPLY DRIVERS
+R:	Pali Rohár <pali.rohar@gmail.com>
-M:	Pali Rohár <pali.rohar@gmail.com>
-S:	Maintained
F:	include/linux/power/bq2415x_charger.h
F:	include/linux/power/bq27xxx_battery.h
F:	include/linux/power/isp1704_charger.h
F:	drivers/power/bq2415x_charger.c
F:	drivers/power/bq27xxx_battery.c
F:	drivers/power/isp1704_charger.c
F:	drivers/power/rx51_battery.c

+TI BQ27XXX POWER SUPPLY DRIVER
+R:	Andrew F. Davis <afd@ti.com>
+F:	include/linux/power/bq27xxx_battery.h
+F:	drivers/power/bq27xxx_battery.c
+F:	drivers/power/bq27xxx_battery_i2c.c
+
POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS
M:	Sebastian Reichel <sre@kernel.org>
M:	Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
M:	David Woodhouse <dwmw2@infradead.org>
L:	linux-pm@vger.kernel.org
T:	git git://git.infradead.org/battery-2.6.git
S:	Maintained
F:	include/linux/power_supply.h
F:	drivers/power/
X:	drivers/power/avs/

This would result in the following get_maintainer.pl output
for the bq27xxx driver.

sre@earth ~/src/linux [n950] % ./scripts/get_maintainer.pl -f drivers/power/bq27xxx_battery.c 
"Andrew F. Davis" <afd@ti.com> (reviewer:TI BQ27XXX POWER SUPPLY DRIVER)
"Pali Rohár" <pali.rohar@gmail.com> (reviewer:NOKIA N900 POWER SUPPLY DRIVERS)
Sebastian Reichel <sre@kernel.org> (maintainer:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS)
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> (maintainer:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS)
David Woodhouse <dwmw2@infradead.org> (maintainer:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS)
linux-pm@vger.kernel.org (open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS)
linux-kernel@vger.kernel.org (open list)

Pali, what do you think about the reviewer/maintainer change?
I think it makes it more clear, that the patches are queued in
the battery tree. If you think its a downgrade I don't mind not
changing it, though.

-- Sebastian

Thread

[PATCH] MAINTAINERS: Add myself as a reviewer for the bq27xxx driver. "Andrew F. Davis" <afd@ti.com> - 2015-12-30 19:40 +0100
  Re: [PATCH] MAINTAINERS: Add myself as a reviewer for the bq27xxx driver. Pali Rohár <pali.rohar@gmail.com> - 2015-12-31 19:50 +0100
    Re: [PATCH] MAINTAINERS: Add myself as a reviewer for the bq27xxx  driver. Sebastian Reichel <sre@kernel.org> - 2015-12-31 22:10 +0100
      Re: [PATCH] MAINTAINERS: Add myself as a reviewer for the bq27xxx driver. Pali Rohár <pali.rohar@gmail.com> - 2015-12-31 22:20 +0100

csiph-web