Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1298378

Re: [PATCH 0/2] Fixes for dell-wmi

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Sunday 27 December 2015 14:10:55 Gabriele Mazzotta wrote:
> On 27/12/2015 14:07, Pali Rohár wrote:
> > On Sunday 27 December 2015 13:59:57 Gabriele Mazzotta wrote:
> >> On 24/12/2015 22:18, Pali Rohár wrote:
> >>> This patch series adds check if Dell WMI descriptor structure is
> >>> valid and fixes processing WMI events on devices with WMI
> >>> interface version 0.
> >>> 
> >>> After testing, second patch is good candidate for backporting
> >>> into stable kernels, but problem is that it cannot be used
> >>> without first patch. So I let decision to other people.
> >>> 
> >>> Gabriele and Michał, this patch series should fix processing
> >>> events on yours Dell laptops (you have in DSDT defined version
> >>> 0). Can you test it?
> >> 
> >> Hi,
> >> 
> >> I tested the patches and all the function keys work, but I can see
> >> that there are some differences in the dmesg.
> >> 
> >> Here a before and after comparison.
> >> 
> >> The radio button seems to generate longer messages when compared
> >> to the others.
> > 
> > Hi! Thanks for testing. Can you please recompile driver with line
> > #define DEBUG at beginning of dell-wmi.c file and send dmesg output
> > again? I want to see processing buffer debug lines in dmesg. Here
> > we should see that after this patch series garbage will not be
> > parsed.
> 
> I had to define DEBUG to get those lines.
> dell_new_hk_type is false, so that's all I can get.

Ah right, now I see... When dell_new_hk_type is false then code below 
which this series changing is not executed.

-- 
Pali Rohár
pali.rohar@gmail.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] Fixes for dell-wmi Pali Rohár <pali.rohar@gmail.com> - 2015-12-24 22:20 +0100
  [PATCH 1/2] dell-wmi: Check if Dell WMI descriptor structure is valid Pali Rohár <pali.rohar@gmail.com> - 2015-12-24 22:30 +0100
    Re: [PATCH 1/2] dell-wmi: Check if Dell WMI descriptor structure is valid Andy Lutomirski <luto@amacapital.net> - 2015-12-25 02:30 +0100
      Re: [PATCH 1/2] dell-wmi: Check if Dell WMI descriptor structure is valid Pali Rohár <pali.rohar@gmail.com> - 2015-12-25 14:10 +0100
    Re: [PATCH 1/2] dell-wmi: Check if Dell WMI descriptor structure is  valid Michał Kępień <kernel@kempniu.pl> - 2015-12-28 14:40 +0100
      Re: [PATCH 1/2] dell-wmi: Check if Dell WMI descriptor structure is valid Pali Rohár <pali.rohar@gmail.com> - 2015-12-28 15:10 +0100
        Re: [PATCH 1/2] dell-wmi: Check if Dell WMI descriptor structure is  valid Michał Kępień <kernel@kempniu.pl> - 2015-12-29 13:50 +0100
          Re: [PATCH 1/2] dell-wmi: Check if Dell WMI descriptor structure is valid Pali Rohár <pali.rohar@gmail.com> - 2015-12-29 17:10 +0100
            Re: [PATCH 1/2] dell-wmi: Check if Dell WMI descriptor structure is  valid Michał Kępień <kernel@kempniu.pl> - 2015-12-30 12:30 +0100
  [PATCH 2/2] dell-wmi: Process only one event on devices with interface version 0 Pali Rohár <pali.rohar@gmail.com> - 2015-12-24 22:30 +0100
    Re: [PATCH 2/2] dell-wmi: Process only one event on devices with  interface version 0 Michał Kępień <kernel@kempniu.pl> - 2015-12-28 14:50 +0100
      Re: [PATCH 2/2] dell-wmi: Process only one event on devices with interface version 0 Pali Rohár <pali.rohar@gmail.com> - 2015-12-28 14:50 +0100
  Re: [PATCH 0/2] Fixes for dell-wmi Pali Rohár <pali.rohar@gmail.com> - 2015-12-27 14:10 +0100
    Re: [PATCH 0/2] Fixes for dell-wmi Pali Rohár <pali.rohar@gmail.com> - 2015-12-27 14:20 +0100
    Re: [PATCH 0/2] Fixes for dell-wmi Gabriele Mazzotta <gabriele.mzt@gmail.com> - 2015-12-27 14:20 +0100
  Re: [PATCH 0/2] Fixes for dell-wmi Gabriele Mazzotta <gabriele.mzt@gmail.com> - 2015-12-27 14:10 +0100
  Re: [PATCH 0/2] Fixes for dell-wmi Michał Kępień <kernel@kempniu.pl> - 2015-12-28 14:40 +0100
    Re: [PATCH 0/2] Fixes for dell-wmi Pali Rohár <pali.rohar@gmail.com> - 2015-12-28 14:50 +0100
      Re: [PATCH 0/2] Fixes for dell-wmi Michał Kępień <kernel@kempniu.pl> - 2015-12-29 13:20 +0100

csiph-web