Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1297160

Re: [RFC PATCH 2/5] crypto: sunxi-ss: fix min3() call to match types

Show all headers | View raw

Hi Arnd,
On 12/22/15 22:06, Arnd Bergmann wrote:
> On Tuesday 22 December 2015, Andre Przywara wrote:
>> The min3() macro expects all arguments to be of the same type (or
>> size at least). While two arguments are ints or u32s, one is size_t,
>> which does not match on 64-bit architectures.
>> Cast the size_t to u32 to make min3() happy. In this context here the
>> length should never exceed 32 bits anyway.
>>
>> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> 
> Looks correct, but a bit ugly. Could we avoid the casts by using
> temporary variables to keep the size_t based data?

I guess this gets even uglier, but I found a better solution by
promoting the other involved variables to size_t in this function. This
works nicely for most of the cases, I just need two size_t casts now.
Will send an updated version soon.

Cheers,
Andre.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH 0/5] arm64: prepare for basic Allwinner support Andre Przywara <andre.przywara@arm.com> - 2015-12-22 13:30 +0100
  [RFC PATCH 5/5] arm64: Introduce Allwinner SoC config option Andre Przywara <andre.przywara@arm.com> - 2015-12-22 13:30 +0100
  [RFC PATCH 2/5] crypto: sunxi-ss: fix min3() call to match types Andre Przywara <andre.przywara@arm.com> - 2015-12-22 13:30 +0100
    Re: [RFC PATCH 2/5] crypto: sunxi-ss: fix min3() call to match types Arnd Bergmann <arnd@arndb.de> - 2015-12-22 23:10 +0100
      Re: [RFC PATCH 2/5] crypto: sunxi-ss: fix min3() call to match types André Przywara <andre.przywara@arm.com> - 2015-12-23 01:10 +0100
  [RFC PATCH 3/5] crypto: sunxi-ss: fix dev_dbg() output type Andre Przywara <andre.przywara@arm.com> - 2015-12-22 13:30 +0100
    Re: [RFC PATCH 3/5] crypto: sunxi-ss: fix dev_dbg() output type Arnd Bergmann <arnd@arndb.de> - 2015-12-22 23:10 +0100
    Re: [RFC PATCH 3/5] crypto: sunxi-ss: fix dev_dbg() output type Corentin LABBE <clabbe.montjoie@gmail.com> - 2015-12-24 14:00 +0100
    Re: [RFC PATCH 3/5] crypto: sunxi-ss: fix dev_dbg() output type Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-12-28 03:50 +0100
  [RFC PATCH 4/5] irqchip: sun4i: fix compilation outside of arch/arm Andre Przywara <andre.przywara@arm.com> - 2015-12-22 13:30 +0100
    Re: [RFC PATCH 4/5] irqchip: sun4i: fix compilation outside of arch/arm Arnd Bergmann <arnd@arndb.de> - 2015-12-22 23:10 +0100
    Re: [RFC PATCH 4/5] irqchip: sun4i: fix compilation outside of  arch/arm Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-12-28 03:50 +0100

csiph-web