Re: [PATCH v3 1/6] acpica: Correct parameter type to acpi_evaluate_dsm

From	Jerry Hoemann <jerry.hoemann@hpe.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 1/6] acpica: Correct parameter type to acpi_evaluate_dsm
Date	2015-12-14 04:30 +0100
Message-ID	<qFrZM-we-9@gated-at.bofh.it> (permalink)
References	<qFqAF-7R7-7@gated-at.bofh.it> <qFqAF-7R7-9@gated-at.bofh.it> <qFqKl-89Q-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Dec 14, 2015 at 03:07:22AM +0100, Rafael J. Wysocki wrote:
> On Mon, Dec 14, 2015 at 2:54 AM, Jerry Hoemann <jerry.hoemann@hpe.com> wrote:
> > The ACPI spec speicifies that arguments "Revision ID" and
> > "Function Index" to a _DSM are type "Integer."  Type Integers
> > are 64 bit quantities.
> >
> > The function evaluate_dsm specifies these types as simple "int"
> > which are 32 bits.  Correct type passed to acpi_evaluate_dsm
> > and its callers and derived callers to pass correct type.
> >
> > acpi_check_dsm and acpi_evaluate_dsm_typed had similar issue
> > and were corrected as well.
> >
> > Signed-off-by: Jerry Hoemann <jerry.hoemann@hpe.com>
> 
> The changes look OK to me, but this is not ACPICA material.
> 
> Please change the subject to something like "ACPI / utils: Fix
> acpi_evaluate_dsm() argument type".
> 
> Thanks,
> Rafael

  Will do.  thanks.

-- 

-----------------------------------------------------------------------------
Jerry Hoemann                  Software Engineer   Hewlett Packard Enterprise
-----------------------------------------------------------------------------
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 1/6] acpica: Correct parameter type to acpi_evaluate_dsm Jerry Hoemann <jerry.hoemann@hpe.com> - 2015-12-14 03:00 +0100
  Re: [PATCH v3 1/6] acpica: Correct parameter type to acpi_evaluate_dsm "Rafael J. Wysocki" <rafael@kernel.org> - 2015-12-14 03:10 +0100
    Re: [PATCH v3 1/6] acpica: Correct parameter type to  acpi_evaluate_dsm Jerry Hoemann <jerry.hoemann@hpe.com> - 2015-12-14 04:30 +0100

csiph-web