Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1291751

[PATCH 6/9] Drivers: hv: ring_buffer: remove stray smp_read_barrier_depends()

Show all headers | View raw

From: Vitaly Kuznetsov <vkuznets@redhat.com>

smp_read_barrier_depends() does nothing on almost all arcitectures
including x86 and having it in the beginning of
hv_get_ringbuffer_availbytes() does not provide any guarantees anyway.

Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
---
 include/linux/hyperv.h |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h
index acd995b..179ff33 100644
--- a/include/linux/hyperv.h
+++ b/include/linux/hyperv.h
@@ -141,8 +141,6 @@ hv_get_ringbuffer_availbytes(struct hv_ring_buffer_info *rbi,
 {
 	u32 read_loc, write_loc, dsize;
 
-	smp_read_barrier_depends();
-
 	/* Capture the read/write indices before they changed */
 	read_loc = rbi->ring_buffer->read_index;
 	write_loc = rbi->ring_buffer->write_index;
-- 
1.7.4.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/9] Drivers: hv: Cleanup ringbuffer code  "K. Y. Srinivasan" <kys@microsoft.com> - 2015-12-15 02:30 +0100
  [PATCH 6/9] Drivers: hv: ring_buffer: remove stray smp_read_barrier_depends() "K. Y. Srinivasan" <kys@microsoft.com> - 2015-12-15 02:30 +0100
  [PATCH 2/9] Drivers: hv: utils: rename outmsg_lock "K. Y. Srinivasan" <kys@microsoft.com> - 2015-12-15 02:30 +0100
  [PATCH 9/9] Drivers: hv: ring_buffer: eliminate hv_ringbuffer_peek() "K. Y. Srinivasan" <kys@microsoft.com> - 2015-12-15 02:30 +0100
  [PATCH 1/9] Drivers: hv: utils: fix memory leak on on_msg() failure "K. Y. Srinivasan" <kys@microsoft.com> - 2015-12-15 02:30 +0100
    [PATCH 3/9] Drivers: hv: utils: introduce HVUTIL_TRANSPORT_DESTROY mode "K. Y. Srinivasan" <kys@microsoft.com> - 2015-12-15 02:40 +0100
      Re: [PATCH 3/9] Drivers: hv: utils: introduce HVUTIL_TRANSPORT_DESTROY mode Vitaly Kuznetsov <vkuznets@redhat.com> - 2015-12-15 18:20 +0100
    [PATCH 4/9] Drivers: hv: utils: fix crash when device is removed from host side "K. Y. Srinivasan" <kys@microsoft.com> - 2015-12-15 02:40 +0100
    [PATCH 5/9] Drivers: hv: ring_buffer.c: fix comment style "K. Y. Srinivasan" <kys@microsoft.com> - 2015-12-15 02:40 +0100

csiph-web