Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1291358

Re: Bad backport of "net: Fix skb_set_peeked use-after-free bug" in 3.18.23

From Sasha Levin <sasha.levin@oracle.com>
Newsgroups linux.kernel
Subject Re: Bad backport of "net: Fix skb_set_peeked use-after-free bug" in 3.18.23
Date 2015-12-14 18:20 +0100
Message-ID <qFEX0-DM-9@gated-at.bofh.it> (permalink)
References <qFrn3-8oD-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 12/13/2015 09:44 PM, Paul Mackerras wrote:
> Commit d9a1133495b4 ("net: Fix skb_set_peeked use-after-free bug") in
> 3.18.23 claims to be a backport of commit a0a2a6602496, but in fact
> the patch is identical to commit 738ac1ebb96d ("net: Clone skb before
> setting peeked flag"), which is the commit that introduces the
> use-after-free bug that a0a2a6602496 fixes.
> 
> The result is that we have been seeing crashes in __skb_recv_datagram
> since I merged v3.18.24 into the kernel code we are using for a
> product.  Could someone fix this with an actual backport of
> a0a2a6602496 please?

Sorry about that, looks like my script has gone haywire :/

I've fixed it, pushed queue and will ship tomorrow after testing.


Thanks,
Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

Bad backport of "net: Fix skb_set_peeked use-after-free bug" in  3.18.23 Paul Mackerras <paulus@ozlabs.org> - 2015-12-14 03:50 +0100
  Re: Bad backport of "net: Fix skb_set_peeked use-after-free bug" in  3.18.23 Sasha Levin <sasha.levin@oracle.com> - 2015-12-14 18:20 +0100

csiph-web