Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1287859
| From | Harish Chegondi <harish.chegondi@intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/2] perf/x86/intel/uncore: Add Knights Landing uncore PMU support |
| Date | 2015-12-09 22:10 +0100 |
| Message-ID | <qDU9R-5bQ-23@gated-at.bofh.it> (permalink) |
| References | <qDcBQ-2jb-19@gated-at.bofh.it> <qDcBR-2jb-29@gated-at.bofh.it> <qDmrw-ks-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 12/08/2015 01:07 AM, Peter Zijlstra wrote: > On Mon, Dec 07, 2015 at 02:32:32PM -0800, Harish Chegondi wrote: >> @@ -981,6 +990,8 @@ static int __init uncore_pci_init(void) >> break; >> case 61: /* Broadwell */ >> ret = bdw_uncore_pci_init(); >> + case 87: /* Knights Landing */ >> + ret = knl_uncore_pci_init(); >> break; >> default: >> return 0; >> @@ -1289,6 +1300,8 @@ static int __init uncore_cpu_init(void) >> break; >> case 86: /* BDX-DE */ >> bdx_uncore_cpu_init(); >> + case 87: /* Knights Landing */ >> + knl_uncore_cpu_init(); >> break; >> default: > Surely you need some extra break statements in there? > . > Yes, I missed the break statements. I will add the breaks in the next version of the patch. Thanks for the review! -Harish. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/2] perf/x86/intel/uncore: Remove hard coding of PMON box control MSR offset Harish Chegondi <harish.chegondi@intel.com> - 2015-12-07 23:40 +0100
[PATCH 2/2] perf/x86/intel/uncore: Add Knights Landing uncore PMU support Harish Chegondi <harish.chegondi@intel.com> - 2015-12-07 23:40 +0100
Re: [PATCH 2/2] perf/x86/intel/uncore: Add Knights Landing uncore PMU support Peter Zijlstra <peterz@infradead.org> - 2015-12-08 10:10 +0100
Re: [PATCH 2/2] perf/x86/intel/uncore: Add Knights Landing uncore PMU support Harish Chegondi <harish.chegondi@intel.com> - 2015-12-09 22:10 +0100
Re: [PATCH 2/2] perf/x86/intel/uncore: Add Knights Landing uncore PMU support Peter Zijlstra <peterz@infradead.org> - 2015-12-10 00:40 +0100
Re: [PATCH 2/2] perf/x86/intel/uncore: Add Knights Landing uncore PMU support Harish Chegondi <harish.chegondi@intel.com> - 2015-12-10 00:50 +0100
csiph-web