Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1287644

Re: [PATCH v2] powercap, intel_rapl.c, fix BIOS lock check

Show all headers | View raw

On Wed,  9 Dec 2015 08:31:12 -0500
Prarit Bhargava <prarit@redhat.com> wrote:

> Intel RAPL initialized on several systems where the BIOS lock bit (msr
> 0x610, bit 63) was set.  This occured because the return value of
> rapl_read_data_raw() was being checked, rather than the value of the
> variable passed in, locked.
> 
> This patch properly implments the rapl_read_data_raw() call to check
> the variable locked, and now the Intel RAPL driver outputs the
> warning:
> 
> 	intel_rapl: RAPL package 0 domain package locked by BIOS
> 
> and does not initialize for the package.
> 
> Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
> Cc: Jacob Pan <jacob.jun.pan@linux.intel.com>
> Cc: Radivoje Jovanovic <radivoje.jovanovic@intel.com>
> Cc: Seiichi Ikarashi <s.ikarashi@jp.fujitsu.com>
> Cc: Mathias Krause <minipli@googlemail.com>
> Cc: Ajay Thomas <ajay.thomas.david.rajamanickam@intel.com>
> Signed-off-by: Prarit Bhargava <prarit@redhat.com>
> 
> [v2]: fix brackets

Acked-by: Jacob Pan <jacob.jun.pan@linux.intel.com>

Good catch by Seiichi, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] powercap, intel_rapl.c, fix BIOS lock check Prarit Bhargava <prarit@redhat.com> - 2015-12-09 14:40 +0100
  Re: [PATCH v2] powercap, intel_rapl.c, fix BIOS lock check Jacob Pan <jacob.jun.pan@linux.intel.com> - 2015-12-09 18:00 +0100
    Re: [PATCH v2] powercap, intel_rapl.c, fix BIOS lock check "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-12-10 00:10 +0100
      Re: [PATCH v2] powercap, intel_rapl.c, fix BIOS lock check Jacob Pan <jacob.jun.pan@linux.intel.com> - 2015-12-10 00:40 +0100
        Re: [PATCH v2] powercap, intel_rapl.c, fix BIOS lock check "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-12-10 01:30 +0100
          Re: [PATCH v2] powercap, intel_rapl.c, fix BIOS lock check Prarit Bhargava <prarit@redhat.com> - 2015-12-10 12:10 +0100
          Re: [PATCH v2] powercap, intel_rapl.c, fix BIOS lock check Jacob Pan <jacob.jun.pan@linux.intel.com> - 2015-12-11 17:40 +0100

csiph-web