Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1285170

Re: [PATCH v2 1/5] power: domain: add pm_genpd_exit

Show all headers | View raw

On 04/12/15 17:45, Eric Anholt wrote:
> From: Alexander Aring <alex.aring@gmail.com>
> 
> This patch adds function pm_genpd_exit for undo a pm_genpd_init. This
> is useful for multiple power domains while probing. If the probing fails
> after one pm_genpd_init was called we need to undo all previous
> registrations of generic pm domains inside the gpd_list list.
> 
> There is a check on IS_ERR_OR_NULL(genpd) which is useful to check again
> registered power domains and not registered domains, the driver can use
> this mechanism to have an array with registered and non-registered power
> domains, where non-registered power domains are NULL.
> 
> Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
> Cc: Kevin Hilman <khilman@kernel.org>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Len Brown <len.brown@intel.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> Signed-off-by: Eric Anholt <eric@anholt.net>
> Acked-by: Ulf Hansson <ulf.hansson@linaro.org>
> ---
>  drivers/base/power/domain.c | 22 ++++++++++++++++++++++
>  include/linux/pm_domain.h   |  4 ++++
>  2 files changed, 26 insertions(+)
> 
> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
> index 167418e..e7aca27 100644
> --- a/drivers/base/power/domain.c
> +++ b/drivers/base/power/domain.c
> @@ -1509,6 +1509,28 @@ void pm_genpd_init(struct generic_pm_domain *genpd,
>  }
>  EXPORT_SYMBOL_GPL(pm_genpd_init);
>  
> +/**
> + * pm_genpd_exit - Uninitialize a generic I/O PM domain object.
> + * @genpd: PM domain object to uninitialize.
> + */
> +void pm_genpd_exit(struct generic_pm_domain *genpd)
> +{
> +	if (IS_ERR_OR_NULL(genpd))
> +		return;
> +
> +	/* check if domain is still in registered inside the pm subsystem */
> +	WARN_ON_ONCE(!list_empty(&genpd->master_links) ||
> +		     !list_empty(&genpd->slave_links) ||
> +		     !list_empty(&genpd->dev_list));
> +

Why not return an error here? Seems bad to remove it, if it could still
be referenced by other domains.

Also not sure if you need to lock around the above test and removing the
domain.

> +	mutex_lock(&gpd_list_lock);
> +	list_del(&genpd->gpd_list_node);
> +	mutex_unlock(&gpd_list_lock);
> +
> +	mutex_destroy(&genpd->lock);
> +}
> +EXPORT_SYMBOL_GPL(pm_genpd_exit);
> +

BTW, I had just submitted a similar patch here [0]. So I would also like
to see such an API added.

Cheers
Jon

[0] http://marc.info/?l=devicetree&m=144924138932726&w=2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/5] Raspberry Pi power domains v2 Eric Anholt <eric@anholt.net> - 2015-12-04 18:50 +0100
  [PATCH v2 3/5] ARM: bcm2835: add rpi power domain driver Eric Anholt <eric@anholt.net> - 2015-12-04 18:50 +0100
    Re: [PATCH v2 3/5] ARM: bcm2835: add rpi power domain driver Kevin Hilman <khilman@kernel.org> - 2015-12-08 00:40 +0100
      Re: [PATCH v2 3/5] ARM: bcm2835: add rpi power domain driver Eric Anholt <eric@anholt.net> - 2015-12-08 02:10 +0100
        Re: [PATCH v2 3/5] ARM: bcm2835: add rpi power domain driver Kevin Hilman <khilman@kernel.org> - 2015-12-08 19:20 +0100
    Re: [PATCH v2 3/5] ARM: bcm2835: add rpi power domain driver Stefan Wahren <info@lategoodbye.de> - 2015-12-11 19:20 +0100
  [PATCH v2 2/5] ARM: bcm2835: Define two new packets from the latest firmware. Eric Anholt <eric@anholt.net> - 2015-12-04 18:50 +0100
  [PATCH v2 1/5] power: domain: add pm_genpd_exit Eric Anholt <eric@anholt.net> - 2015-12-04 19:00 +0100
    Re: [PATCH v2 1/5] power: domain: add pm_genpd_exit Jon Hunter <jonathanh@nvidia.com> - 2015-12-07 11:10 +0100
      Re: [PATCH v2 1/5] power: domain: add pm_genpd_exit Kevin Hilman <khilman@kernel.org> - 2015-12-08 20:00 +0100
        Re: [PATCH v2 1/5] power: domain: add pm_genpd_exit Alexander Aring <alex.aring@gmail.com> - 2015-12-09 11:50 +0100
          Re: [PATCH v2 1/5] power: domain: add pm_genpd_exit Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-12-09 12:00 +0100

csiph-web