Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1284656

Re: [PATCH net-next 2/2] net: hns: enet specisies a reference to dsaf (config and documents)

Show all headers | View raw

On Saturday 05 December 2015 14:10:56 yankejian wrote:
> diff --git a/Documentation/devicetree/bindings/net/hisilicon-hns-dsaf.txt b/Documentation/devicetree/bindings/net/hisilicon-hns-dsaf.txt
> index 80411b2..ecacfa4 100644
> --- a/Documentation/devicetree/bindings/net/hisilicon-hns-dsaf.txt
> +++ b/Documentation/devicetree/bindings/net/hisilicon-hns-dsaf.txt
> @@ -4,8 +4,6 @@ Required properties:
>  - compatible: should be "hisilicon,hns-dsaf-v1" or "hisilicon,hns-dsaf-v2".
>    "hisilicon,hns-dsaf-v1" is for hip05.
>    "hisilicon,hns-dsaf-v2" is for Hi1610 and Hi1612.
> -- dsa-name: dsa fabric name who provide this interface.
> -  should be "dsafX", X is the dsaf id.
>  - mode: dsa fabric mode string. only support one of dsaf modes like these:
>                 "2port-64vf",
>                 "6port-16rss",
> @@ -26,9 +24,8 @@ Required properties:
>  
>  Example:
>  
> -dsa: dsa@c7000000 {
> +dsaf0: dsa@c7000000 {
>         compatible = "hisilicon,hns-dsaf-v1";
> -       dsa_name = "dsaf0";
>         mode = "6port-16rss";
>         interrupt-parent = <&mbigen_dsa>;
>         reg = <0x0 0xC0000000 0x0 0x420000
> diff --git a/Documentation/devicetree/bindings/net/hisilicon-hns-nic.txt b/Documentation/devicetree/bindings/net/hisilicon-hns-nic.txt
> index 41d19be..e6a9d1c 100644
> --- a/Documentation/devicetree/bindings/net/hisilicon-hns-nic.txt
> +++ b/Documentation/devicetree/bindings/net/hisilicon-hns-nic.txt
> @@ -4,8 +4,9 @@ Required properties:
>  - compatible: "hisilicon,hns-nic-v1" or "hisilicon,hns-nic-v2".
>    "hisilicon,hns-nic-v1" is for hip05.
>    "hisilicon,hns-nic-v2" is for Hi1610 and Hi1612.
> -- ae-name: accelerator name who provides this interface,
> -  is simply a name referring to the name of name in the accelerator node.
> +- ae-handle: accelerator engine handle for hns,
> +  specifies a reference to the associating hardware driver node.
> +  see Documentation/devicetree/bindings/net/hisilicon-hns-dsaf.txt
>  - port-id: is the index of port provided by DSAF (the accelerator). DSAF can
>    connect to 8 PHYs. Port 0 to 1 are both used for adminstration purpose. They
>    are called debug ports.
> @@ -41,7 +42,7 @@ Example:
>  
> 

This looks like an incompatible change, as you add and remove
required properties. Is there a way to support both the old and
the new style?

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next 2/2] net: hns: enet specisies a reference to dsaf (config and documents) yankejian <yankejian@huawei.com> - 2015-12-05 07:00 +0100
  Re: [PATCH net-next 2/2] net: hns: enet specisies a reference to dsaf (config and documents) Arnd Bergmann <arnd@arndb.de> - 2015-12-05 23:30 +0100
    Re: [PATCH net-next 2/2] net: hns: enet specisies a reference to dsaf  (config and documents) "Yankejian (Hackim Yim)" <yankejian@huawei.com> - 2015-12-07 08:20 +0100
      arRe: [PATCH net-next 2/2] net: hns: enet specisies a reference to dsaf (config and documents) Arnd Bergmann <arnd@arndb.de> - 2015-12-07 10:50 +0100
        Re: arRe: [PATCH net-next 2/2] net: hns: enet specisies a reference  to dsaf (config and documents) "Yankejian (Hackim Yim)" <yankejian@huawei.com> - 2015-12-09 10:30 +0100
          Re: arRe: [PATCH net-next 2/2] net: hns: enet specisies a reference to dsaf (config and documents) Arnd Bergmann <arnd@arndb.de> - 2015-12-09 11:10 +0100
            Re: arRe: [PATCH net-next 2/2] net: hns: enet specisies a reference  to dsaf (config and documents) "Yankejian (Hackim Yim)" <yankejian@huawei.com> - 2015-12-09 11:30 +0100

csiph-web