Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1281806

Re: [PATCH 04/10] vfs: Distinguish between full xattr names and proper prefixes

Show all headers | View raw

On Tue, Dec 1, 2015 at 10:42 AM, James Morris <jmorris@namei.org> wrote:
> On Mon, 30 Nov 2015, Andreas Gruenbacher wrote:
>
>> Add an additional "name" field to struct xattr_handler.  When the name
>> is set, the handler matches attributes with exactly that name.  When the
>> prefix is set instead, the handler matches attributes with the given
>> prefix and with a non-empty suffix.
>>
>> This patch should avoid bugs like the one fixed in commit c361016a in
>> the future.
>>
>> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
>
> Is it worth making an inline wrapper for 'handler->prefix ?:
> handler->name' ?

Yes, I did that.

Thanks,
Andreas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/10] xattr cleanups Andreas Gruenbacher <agruenba@redhat.com> - 2015-11-30 22:50 +0100
  [PATCH 03/10] posix acls: Remove duplicate xattr name definitions Andreas Gruenbacher <agruenba@redhat.com> - 2015-11-30 22:50 +0100
  [PATCH 01/10] vfs: Remove vfs_xattr_cmp Andreas Gruenbacher <agruenba@redhat.com> - 2015-11-30 22:50 +0100
    Re: [PATCH 01/10] vfs: Remove vfs_xattr_cmp James Morris <jmorris@namei.org> - 2015-12-01 10:40 +0100
  [PATCH 05/10] btrfs: Use xattr handler infrastructure Andreas Gruenbacher <agruenba@redhat.com> - 2015-11-30 22:50 +0100
    Re: [PATCH 05/10] btrfs: Use xattr handler infrastructure David Sterba <dsterba@suse.cz> - 2015-12-01 16:20 +0100
  [PATCH 06/10] tmpfs: Use xattr handler infrastructure Andreas Gruenbacher <agruenba@redhat.com> - 2015-11-30 22:50 +0100
  [PATCH 09/10] nfs: Move call to security_inode_listsecurity into nfs_listxattr Andreas Gruenbacher <agruenba@redhat.com> - 2015-11-30 22:50 +0100
  [PATCH 04/10] vfs: Distinguish between full xattr names and proper prefixes Andreas Gruenbacher <agruenba@redhat.com> - 2015-11-30 22:50 +0100
    Re: [PATCH 04/10] vfs: Distinguish between full xattr names and  proper prefixes James Morris <jmorris@namei.org> - 2015-12-01 10:50 +0100
      Re: [PATCH 04/10] vfs: Distinguish between full xattr names and  proper prefixes Andreas Gruenbacher <agruenba@redhat.com> - 2015-12-02 14:50 +0100
  [PATCH 10/10] xattr handlers: Simplify list operation Andreas Gruenbacher <agruenba@redhat.com> - 2015-11-30 22:50 +0100
    Re: [PATCH 10/10] xattr handlers: Simplify list operation James Morris <jmorris@namei.org> - 2015-12-01 11:00 +0100
      Re: [PATCH 10/10] xattr handlers: Simplify list operation Andreas Grünbacher <andreas.gruenbacher@gmail.com> - 2015-12-01 11:40 +0100
  [PATCH 02/10] gfs2: Remove gfs2_xattr_acl_chmod Andreas Gruenbacher <agruenba@redhat.com> - 2015-11-30 22:50 +0100
    Re: [PATCH 02/10] gfs2: Remove gfs2_xattr_acl_chmod James Morris <jmorris@namei.org> - 2015-12-01 10:40 +0100
    Re: [PATCH 02/10] gfs2: Remove gfs2_xattr_acl_chmod Bob Peterson <rpeterso@redhat.com> - 2015-12-01 20:10 +0100

csiph-web