Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1283799

Re: [PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell Vostro V131

Show all headers | View raw

> > On some laptop models (e.g. Dell Vostro V131), pressing the Dell Instant
> > Launch hotkey does not raise an i8042 interrupt - only WMI event 0xe025
> > is generated.  As there seems to be no ACPI method or SMI call to
> > determine without possible side effects whether a given machine is
> > capable of simulating a keypress when this hotkey is pressed, DMI
> > matching is used to whitelist the models for which an input event should
> > be generated when WMI event 0xe025 is received.
> > 
> > Signed-off-by: Michał Kępień <kernel@kempniu.pl>
> > ---
> > Changes from v1:
> > 
> >   - Use DMI matching instead of a module parameter
> >   - Change flag name to improve readability
> > 
> > Darren, I am aware this patch conflicts with Andy's WMI rework series
> > posted yesterday, so please just let me know if you want me to rebase.
> 
> Thanks for the heads' up. Andy's series is longer and likely going to need more
> review from more people, so I don't necessarily want to hold this one up on it -
> unless it makes sense to include it in that series so they can evolve together.
> I'll leave that to you and Andy to decide.

As merging my patch with Andy's work is just a matter of moving code
around, not actually changing it, personally I don't feel this patch
should be somehow linked to the WMI rework.  Andy, please let me know if
you disagree, I don't really have any strong feelings about this.

-- 
Best regards,
Michał Kępień
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] dell-wmi: add module param to control Dell Instant  Launch hotkey processing Darren Hart <dvhart@infradead.org> - 2015-11-30 22:20 +0100
  Re: [PATCH] dell-wmi: add module param to control Dell Instant  Launch hotkey processing Michał Kępień <kernel@kempniu.pl> - 2015-12-01 09:50 +0100
  [PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell Vostro V131 Michał Kępień <kernel@kempniu.pl> - 2015-12-01 21:00 +0100
    Re: [PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell  Vostro V131 Darren Hart <dvhart@infradead.org> - 2015-12-04 02:20 +0100
      Re: [PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell  Vostro V131 Pali Rohár <pali.rohar@gmail.com> - 2015-12-04 10:00 +0100
        Re: [PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell  Vostro V131 Michał Kępień <kernel@kempniu.pl> - 2015-12-04 14:30 +0100
      Re: [PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell  Vostro V131 Michał Kępień <kernel@kempniu.pl> - 2015-12-04 14:00 +0100
        Re: [PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell  Vostro V131 Andy Lutomirski <luto@amacapital.net> - 2015-12-04 17:10 +0100
    Re: [PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell  Vostro V131 Pali Rohár <pali.rohar@gmail.com> - 2015-12-04 09:50 +0100
      Re: [PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell  Vostro V131 Michał Kępień <kernel@kempniu.pl> - 2015-12-04 13:40 +0100

csiph-web