Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1280042
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] ASoC: sun4i: Implement MIC1 capture |
| Date | 2015-11-30 17:20 +0100 |
| Message-ID | <qAzlf-5Uw-5@gated-at.bofh.it> (permalink) |
| References | <qAySe-5tX-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Mon, Nov 30, 2015 at 04:37:47PM +0100, Maxime Ripard wrote:
A couple of minor issues below but I'll apply this - please send
followup patches.
> +static void sun4i_codec_start_capture(struct sun4i_codec *scodec)
> +{
> + /*
> + * FIXME: according to the BSP, we might need to drive a PA
> + * GPIO high here on some boards
> + */
That's not something this driver needs to worry about, that's something
the machine driver will do - the whole purpose is to glue all the
different components on the board together.
> + if (clk_set_rate(scodec->clk_module, clk_freq))
> + return -EINVAL;
It'd be better to pass back the error code from clk_set_rate().
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] ASoC: sun4i: Implement MIC1 capture Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-11-30 16:50 +0100
Re: [PATCH] ASoC: sun4i: Implement MIC1 capture Mark Brown <broonie@kernel.org> - 2015-11-30 17:20 +0100
Re: [PATCH] ASoC: sun4i: Implement MIC1 capture Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-12-01 10:20 +0100
Re: [PATCH] ASoC: sun4i: Implement MIC1 capture kbuild test robot <lkp@intel.com> - 2015-11-30 17:30 +0100
csiph-web