Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1280337

Re: [PATCH] bugfix oom kill init lead panic

From David Rientjes <rientjes@google.com>
Newsgroups linux.kernel
Subject Re: [PATCH] bugfix oom kill init lead panic
Date 2015-11-30 23:10 +0100
Message-ID <qAENY-YF-13@gated-at.bofh.it> (permalink)
References <qAmR3-613-3@gated-at.bofh.it> <qAn0J-6jz-5@gated-at.bofh.it> <qAntM-6zI-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Mon, 30 Nov 2015, Chenjie (K) wrote:

> My kernel version is 3.10 ,but the 4.3 is the same
> and the newest code is
> 
> 	for_each_process(p) {
> 		if (!process_shares_mm(p, mm))
> 			continue;
> 		if (same_thread_group(p, victim))
> 			continue;
> 		if (unlikely(p->flags & PF_KTHREAD))
> 			continue;
> 		if (p->signal->oom_score_adj == OOM_SCORE_ADJ_MIN)
> 			continue;
> 
> so this not add the !is_global_init also.
> 
> when we vfork (CLONE_VM) a process,the copy_mm
> 	if (clone_flags & CLONE_VM) {
> 		atomic_inc(&oldmm->mm_users);
> 		mm = oldmm;
> 		goto good_mm;
> 	}
> use the parent mm.
> 

I think it might be a legitimate fix, but if the oom killer is killing pid 
9134 in your log then I assume the next call to the oom killer will panic 
the system anyway unless there is actually a process using less memory 
that can be killed.  Would you mind enabling vm.oom_dump_tasks (it should 
default to enabled) and post the entire oom killer log?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] bugfix oom kill init lead panic <chenjie6@huawei.com> - 2015-11-30 04:00 +0100
  Re: [PATCH] bugfix oom kill init lead panic Andrew Morton <akpm@linux-foundation.org> - 2015-11-30 04:10 +0100
    Re: [PATCH] bugfix oom kill init lead panic "Chenjie (K)" <chenjie6@huawei.com> - 2015-11-30 04:40 +0100
      Re: [PATCH] bugfix oom kill init lead panic David Rientjes <rientjes@google.com> - 2015-11-30 23:10 +0100
        Re: [PATCH] bugfix oom kill init lead panic "Chenjie (K)" <chenjie6@huawei.com> - 2015-12-01 05:20 +0100
  Re: [PATCH] bugfix oom kill init lead panic David Rientjes <rientjes@google.com> - 2015-12-02 00:50 +0100

csiph-web