Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1280122

Re: [PATCH] sched: Move sched_to_prio arrays out of line

Show all headers | View raw

On Mon, Nov 30, 2015 at 10:03:13AM +0100, Peter Zijlstra wrote:
> On Sun, Nov 29, 2015 at 08:59:43PM -0800, Andi Kleen wrote:
> > From: Andi Kleen <ak@linux.intel.com>
> > 
> > When building a kernel with a gcc 6 snapshot the compiler complains
> > about unused const static variables for prio_to_weight and prio_to_mult
> > for multiple scheduler files (all but core.c and autogroup.c)
> > 
> > The way the array is currently declared it will be duplicated in
> > every scheduler file that includes sched.h, which seems rather wasteful.
> 
> Yeah, that's not right.
> 
> > Move the array out of line into core.c. I also added a sched_ prefix
> > to avoid any potential name space collisions.
> 
> Thanks!

Thanks. Please make sure the merge v2, v1 had one missing conversion.

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] sched: Move sched_to_prio arrays out of line Andi Kleen <andi@firstfloor.org> - 2015-11-30 06:10 +0100
  Re: [PATCH] sched: Move sched_to_prio arrays out of line Peter Zijlstra <peterz@infradead.org> - 2015-11-30 10:10 +0100
    Re: [PATCH] sched: Move sched_to_prio arrays out of line Andi Kleen <ak@linux.intel.com> - 2015-11-30 18:20 +0100
  [tip:sched/core] sched/core: Move the sched_to_prio[]   arrays out of line tip-bot for Andi Kleen <tipbot@zytor.com> - 2015-12-04 13:00 +0100

csiph-web