Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1225588

Re: [PATCH 1/5 v2] mm/memblock: Introduce memblock_first_region_size() helper

Show all headers | View raw

On Tue,  1 Sep 2015 20:27:11 +0600 Alexander Kuleshov <kuleshovmail@gmail.com> wrote:

> Some architectures (like s390, microblaze and etc...) require size
> of the first memory region. This patch provides new memblock_first_region_size()
> helper for this case.
> 
> ...
>
> +phys_addr_t __init_memblock memblock_first_region_size(void)
> +{
> +	return memblock.memory.regions[0].size;
> +}
> +

Some callers call this from __init code, which is OK.

Other callers call it from an inlined function and I'm too lazy to work
out if all the callers of those callers are calling
memblock_first_region_size() from a compatible section.

So please either a) demonstrate that all the sectioning is correct (and
maintainable!) or b) simply inline memblock_first_region_size()...

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 1/5 v2] mm/memblock: Introduce  memblock_first_region_size() helper Andrew Morton <akpm@linux-foundation.org> - 2015-09-16 01:40 +0200

csiph-web