Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1225330

Re: [PATCH v1 0/3] lib/string: introduce match_string() helper

Show all headers | View raw

Hello,

On Tue, Sep 15, 2015 at 09:53:48AM +0300, Andy Shevchenko wrote:
> There are users of a simple string matching in the array. Let's do a common
> helper for that.
> 
> Two users are updated in the series. one more is coming [1].
> 
> [1] http://www.spinics.net/lists/kernel/msg2074265.html
> 
> The series is compile tested.
> 
> Andy Shevchenko (3):
>   lib/string: introduce match_string() helper
>   drm/edid: convert to use match_string() helper
>   ata: hpt366: convert to use match_string() helper
> 
>  drivers/ata/pata_hpt366.c       | 13 +++++--------
>  drivers/gpu/drm/drm_edid_load.c | 17 ++++++-----------
>  include/linux/string.h          |  7 +++++++
>  lib/string.c                    | 26 ++++++++++++++++++++++++++
>  4 files changed, 44 insertions(+), 19 deletions(-)

While increase in LOC isn't the only indicator, we're adding two
helper functions each for two usages.  I'm not quite sure the addition
of helpers is paying off here.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v1 0/3] lib/string: introduce match_string() helper Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-09-15 09:00 +0200
  [PATCH v1 2/3] drm/edid: convert to use match_string() helper Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-09-15 09:00 +0200
  [PATCH v1 3/3] ata: hpt366: convert to use match_string() helper Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-09-15 09:00 +0200
  [PATCH v1 1/3] lib/string: introduce match_string() helper Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-09-15 09:00 +0200
  Re: [PATCH v1 0/3] lib/string: introduce match_string() helper Tejun Heo <tj@kernel.org> - 2015-09-15 17:40 +0200

csiph-web