Re: [PATCH V2 3/3] reset: hi6220: Reset driver for hisilicon hi6220 SoC

From	chenfeng <puck.chen@hisilicon.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH V2 3/3] reset: hi6220: Reset driver for hisilicon hi6220 SoC
Date	2015-09-14 04:10 +0200
Message-ID	<q8rns-DI-1@gated-at.bofh.it> (permalink)
References	<q7rSy-4w9-11@gated-at.bofh.it> <q7rSy-4w9-9@gated-at.bofh.it> <q7sbT-4SS-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 2015/9/11 16:41, Arnd Bergmann wrote:
> On Friday 11 September 2015 16:18:38 Chen Feng wrote:
>> +static int __init hi6220_reset_init(void)
>> +{
>> +	int ret;
>> +	struct device_node *np;
>> +	struct hi6220_reset_data *data;
>> +
>> +	data = kzalloc(sizeof(*data), GFP_KERNEL);
>> +	if (!data)
>> +		return -ENOMEM;
>> +
>> +	np = of_find_compatible_node(NULL, NULL, "hisilicon,hi6220_reset_ctl");
>> +	if (!np) {
>> +		ret = -ENXIO;
>> +		goto err_alloc;
>> +	}
> 
> Why is this not a platform driver?
> 
OK,I will change this to a platform driver.

>> +	if (IS_ENABLED(CONFIG_RESET_CONTROLLER))
>> +		reset_controller_register(&data->rc_dev);
>> +
>> +	return 0;
> 
> The Kconfig symbol already depends on RESET_CONTROLLER, so
> the IS_ENABLED() check looks redundant.
> 
Yes,agree with you.
> 	Arnd
> 
> .
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH V2 3/3] reset: hi6220: Reset driver for hisilicon hi6220 SoC Chen Feng <puck.chen@hisilicon.com> - 2015-09-11 10:30 +0200
  Re: [PATCH V2 3/3] reset: hi6220: Reset driver for hisilicon hi6220 SoC Arnd Bergmann <arnd@arndb.de> - 2015-09-11 10:50 +0200
    Re: [PATCH V2 3/3] reset: hi6220: Reset driver for hisilicon hi6220  SoC chenfeng <puck.chen@hisilicon.com> - 2015-09-14 04:10 +0200
  Re: [PATCH V2 3/3] reset: hi6220: Reset driver for hisilicon hi6220  SoC xuyiping <xuyiping@hisilicon.com> - 2015-09-12 08:30 +0200
    Re: [PATCH V2 3/3] reset: hi6220: Reset driver for hisilicon hi6220  SoC chenfeng <puck.chen@hisilicon.com> - 2015-09-14 04:10 +0200

csiph-web