Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1224975

Re: [PATCH] tpm, tpm_crb: fix unaligned read of the command buffer address

Show all headers | View raw

On Mon, Sep 14, 2015 at 11:35:23AM -0600, Jason Gunthorpe wrote:
> On Mon, Sep 14, 2015 at 08:15:23PM +0300, Jarkko Sakkinen wrote:
> > The command buffer address is necessarily not naturally aligned.
> > The hardware drops the entire read on some platforms and fills the
> > address with 1's. This patch fixes the issue by splitting the read
> > into two 32 bit reads.
> 
> Is this necessary? The packed attribution means that unaligned members
> are allowed and the compiler deals with it where necessary.

For regular memory memory controller splits the read into two 32 bit
reads.

However, for MMIO address the hardware might abort the entire request
when trying to do a 64-bit read, which causes the CPU to fill the result
with 1's.

This is not hypothetical bug. We are experiencing this on some platforms
and the proposed fix resolves the issue.

> Jason

/Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] tpm, tpm_crb: fix unaligned read of the command buffer address Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2015-09-14 19:20 +0200
  Re: [PATCH] tpm, tpm_crb: fix unaligned read of the command buffer  address Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2015-09-14 19:40 +0200
    Re: [PATCH] tpm, tpm_crb: fix unaligned read of the command buffer  address Jarkko Sakkinen <jarkko.sakkinen@intel.com> - 2015-09-15 12:20 +0200
      Re: [PATCH] tpm, tpm_crb: fix unaligned read of the command buffer  address Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2015-09-15 18:40 +0200
        Re: [PATCH] tpm, tpm_crb: fix unaligned read of the command buffer  address Jarkko Sakkinen <jarkko.sakkinen@intel.com> - 2015-09-15 18:50 +0200

csiph-web