Re: [PATCH 6/7] ARM: brcmstb: mask GIC IRQs on suspend

From	Florian Fainelli <f.fainelli@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 6/7] ARM: brcmstb: mask GIC IRQs on suspend
Date	2015-09-14 19:50 +0200
Message-ID	<q8G38-4M8-15@gated-at.bofh.it> (permalink)
References	<pCSci-7EU-7@gated-at.bofh.it> <pCSci-7EU-19@gated-at.bofh.it> <q7Z7Q-23j-7@gated-at.bofh.it> <q8G38-4M8-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 14/09/15 10:42, Brian Norris wrote:
> One more thing:
> 
> On Sat, Sep 12, 2015 at 12:53:32PM -0700, Florian Fainelli wrote:
>> Le 06/18/15 17:11, Brian Norris a écrit :
>>> Lazily-masked IRQs can cause system suspend problems (e.g., spurious
>>> wakeups from WFI), so we need to be sure non-wakeup GIC interrupts get
>>> masked, not just disabled, during system suspend.
>>>
>>> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
>>
>> Dropped this patch, no longer needed as of 4.3-rc0 with
>> aec89ef72ba6c94420f599dcb684ed66937cdacf ("irqchip/gic: Enable
>> SKIP_SET_WAKE and MASK_ON_SUSPEND")
> 
> With this patch dropped, then we really don't need
> arch/arm/mach-bcm/brcmstb.c any more, AFAICT. Unless you have more plans
> for this file, I can send a patch...

I am in the process of cleaning up the BIU control register setup for
the memory controller write-pairing support to get that submitted, and
that needs to be initialized before SMP, so we will still need an entry
point in the machine code to do that.

Thanks!
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH 6/7] ARM: brcmstb: mask GIC IRQs on suspend Florian Fainelli <f.fainelli@gmail.com> - 2015-09-12 22:00 +0200
  Re: [PATCH 6/7] ARM: brcmstb: mask GIC IRQs on suspend Brian Norris <computersforpeace@gmail.com> - 2015-09-14 19:30 +0200
  Re: [PATCH 6/7] ARM: brcmstb: mask GIC IRQs on suspend Florian Fainelli <f.fainelli@gmail.com> - 2015-09-14 19:50 +0200
  Re: [PATCH 6/7] ARM: brcmstb: mask GIC IRQs on suspend Brian Norris <computersforpeace@gmail.com> - 2015-09-14 19:50 +0200

csiph-web