Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1222695

Re: [PATCH] check_for_tasks: read_lock(tasklist_lock) doesn't need to disable irqs

Show all headers | View raw

* Oleg Nesterov <oleg@redhat.com> [2015-09-10 15:07:50]:

> check_for_tasks() doesn't need to disable irqs, recursive read_lock()
> from interrupt is fine.
> 
> While at it, s/do_each_thread/for_each_process_thread/.
> 
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>

Looks good to me.

Reviewed-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>

> ---
>  kernel/cpu.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 

-- 
Thanks and Regards
Srikar Dronamraju

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] check_for_tasks: read_lock(tasklist_lock) doesn't need to  disable irqs Oleg Nesterov <oleg@redhat.com> - 2015-09-10 15:20 +0200
  Re: [PATCH] check_for_tasks: read_lock(tasklist_lock) doesn't need  to disable irqs Kirill Tkhai <ktkhai@odin.com> - 2015-09-10 15:40 +0200
  Re: [PATCH] check_for_tasks: read_lock(tasklist_lock) doesn't need  to disable irqs Srikar Dronamraju <srikar@linux.vnet.ibm.com> - 2015-09-11 12:30 +0200
  [tip:sched/core] cpu/hotplug: Read_lock(tasklist_lock) doesn'  t need to disable irqs tip-bot for Oleg Nesterov <tipbot@zytor.com> - 2015-09-13 13:00 +0200

csiph-web