Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1222279

Re: [PATCH] toshiba_acpi: Fix hotkeys registration on some toshiba models

Show all headers | View raw

On Wed, Sep 09, 2015 at 11:25:45AM -0600, Azael Avalos wrote:
> Commit a2b3471b5b13 ("toshiba_acpi: Use the Hotkey Event Type function
> for keymap choosing") changed the *setup_keyboard function to query for
> the Hotkey Event Type to help choose the correct keymap, but turns out
> that here are certain Toshiba models out there not implementing this
> feature, and thus, failing to continue the input device registration and
> leaving such laptops without hotkey support.
> 
> This patch changes such check, and instead of returning an error if
> the Hotkey Event Type is not present, we simply inform userspace about it,
> changing the message printed from err to notice, making the function
> responsible for registering the input device to continue.
> 
> This issue was found on a Toshiba Portege Z30-B, but there might be
> some other models out there affected by this regression as well.
> 
> Cc: <stable@vger.kernel.org> # 4.1+
> Signed-off-by: Azael Avalos <coproscefalo@gmail.com>

Queued for 4.3, thanks!

-- 
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] toshiba_acpi: Fix hotkeys registration on some toshiba models Azael Avalos <coproscefalo@gmail.com> - 2015-09-09 19:30 +0200
  Re: [PATCH] toshiba_acpi: Fix hotkeys registration on some toshiba  models Darren Hart <dvhart@infradead.org> - 2015-09-10 18:30 +0200

csiph-web