Groups > linux.kernel > #1221920

Re: [PATCH] ipv6: fix ifnullfree.cocci warnings

From	roopa <roopa@cumulusnetworks.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ipv6: fix ifnullfree.cocci warnings
Date	2015-09-10 07:10 +0200
Message-ID	<q72hr-bR-7@gated-at.bofh.it> (permalink)
References	<q6Wvo-8wd-13@gated-at.bofh.it> <q6Wvo-8wd-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 9/9/15, 3:57 PM, kbuild test robot wrote:
> net/ipv6/route.c:2946:3-8: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
>
>   NULL check before some freeing functions is not needed.
>
>   Based on checkpatch warning
>   "kfree(NULL) is safe this check is probably not required"
>   and kfreeaddr.cocci by Julia Lawall.
>
> Generated by: scripts/coccinelle/free/ifnullfree.cocci
>
> CC: Roopa Prabhu <roopa@cumulusnetworks.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
>
FWIW, Acked-by: Roopa Prabhu <roopa@cumulusnetworks.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ipv6: fix ifnullfree.cocci warnings kbuild test robot <fengguang.wu@intel.com> - 2015-09-10 01:00 +0200
  Re: [PATCH] ipv6: fix ifnullfree.cocci warnings David Miller <davem@davemloft.net> - 2015-09-10 02:30 +0200
  Re: [PATCH] ipv6: fix ifnullfree.cocci warnings roopa <roopa@cumulusnetworks.com> - 2015-09-10 07:10 +0200

csiph-web