Re: [PATCH] net: stmmac: Use msleep rather then udelay for reset delay

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net: stmmac: Use msleep rather then udelay for reset delay
Date	2015-09-09 07:50 +0200
Message-ID	<q6GqB-2fO-1@gated-at.bofh.it> (permalink)
References	<q5Kwh-3cv-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Date: Sun,  6 Sep 2015 17:50:59 +0200

> @@ -161,11 +161,16 @@ int stmmac_mdio_reset(struct mii_bus *bus)
>  
>  		if (!gpio_request(reset_gpio, "mdio-reset")) {
>  			gpio_direction_output(reset_gpio, active_low ? 1 : 0);
> -			udelay(data->delays[0]);
> +			if (data->delays[0])
> +				msleep((data->delays[0] + 999) / 1000);

Please use something like DIV_ROUND_UP(..., USEC_PER_MSEC) or similar.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] net: stmmac: Use msleep rather then udelay for reset  delay David Miller <davem@davemloft.net> - 2015-09-09 07:50 +0200

csiph-web