Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1220129

Re: [PATCH] btrfs: memset cur_trans->delayed_refs to zero

Show all headers | View raw

On Sun, Sep 06, 2015 at 12:25:27PM +0000, Alexandru Moise wrote:
> Use memset() to null out the btrfs_delayed_ref_root of
> btrfs_transaction instead of setting all the members to 0 by hand.
> 
> Signed-off-by: Alexandru Moise <00moses.alexander00@gmail.com>
> ---
>  fs/btrfs/transaction.c | 10 +---------
>  1 file changed, 1 insertion(+), 9 deletions(-)
> 
> diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c
> index 8f259b3..faccc1b 100644
> --- a/fs/btrfs/transaction.c
> +++ b/fs/btrfs/transaction.c
> @@ -224,15 +224,7 @@ loop:
>  	cur_trans->start_time = get_seconds();
>  	cur_trans->dirty_bg_run = 0;
>  
> -	cur_trans->delayed_refs.href_root = RB_ROOT;
> -	cur_trans->delayed_refs.dirty_extent_root = RB_ROOT;
> -	atomic_set(&cur_trans->delayed_refs.num_entries, 0);

Please keep these. Even if it means duplicated setting to 0, it's using
the correct constructor, should it ever change (RB_ROOT) or does some
extra work (atomic_set).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] btrfs: memset cur_trans->delayed_refs to zero Alexandru Moise <00moses.alexander00@gmail.com> - 2015-09-06 11:30 +0200
  Re: [PATCH] btrfs: memset cur_trans->delayed_refs to zero David Sterba <dsterba@suse.cz> - 2015-09-07 14:30 +0200
    Re: [PATCH] btrfs: memset cur_trans->delayed_refs to zero Alexandru Moise <00moses.alexander00@gmail.com> - 2015-09-07 15:50 +0200

csiph-web