Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1220041

Re: [PATCH 1/4] ARM: multi_v7_defconfig: Enable common Rockchip devices/busses

Show all headers | View raw

On Mon, 2015-09-07 at 11:26 +0200, Javier Martinez Canillas wrote:
> Hello Sjoerd,
> 
> On 09/06/2015 10:16 PM, Sjoerd Simons wrote:
> > Enable Rockchip I2C, SPI, PWM, thermal drivers.
> > 
> > Builtin are:
> >  * I2C as it often controls the pmic.
> 
> Having I2C as a module will cause more probe deferrals due missing
> regulators and slow down the boot but it should not cause issues.
> Or am I missing something?
> 
> In fact, I think even the PMIC could be built as a module.

It could in principle. However as a lot of other drivers do need the
regulators provided by the pmic, they'll be deferred until that driver
is loaded. So e.g. with the i2c/pmic drivers as a module you cannot
boot to an NFS rootfs without using an initramfs. 

> But I don't have a strong opinion on this so patch looks good:
> 
> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 
> Best regards,

-- 
Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Collabora Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/4] ARM: multi_v7_defconfig: Enable common Rockchip devices/busses Sjoerd Simons <sjoerd.simons@collabora.co.uk> - 2015-09-06 22:20 +0200
  Re: [PATCH 1/4] ARM: multi_v7_defconfig: Enable common Rockchip  devices/busses Javier Martinez Canillas <javier@osg.samsung.com> - 2015-09-07 11:30 +0200
    Re: [PATCH 1/4] ARM: multi_v7_defconfig: Enable common Rockchip  devices/busses Sjoerd Simons <sjoerd.simons@collabora.co.uk> - 2015-09-07 12:30 +0200
      Re: [PATCH 1/4] ARM: multi_v7_defconfig: Enable common Rockchip  devices/busses Javier Martinez Canillas <javier@osg.samsung.com> - 2015-09-07 12:40 +0200
        Re: [PATCH 1/4] ARM: multi_v7_defconfig: Enable common Rockchip  devices/busses Thierry Reding <treding@nvidia.com> - 2015-09-07 13:30 +0200
      Re: [PATCH 1/4] ARM: multi_v7_defconfig: Enable common Rockchip  devices/busses Andy Yan <andy.yan@rock-chips.com> - 2015-09-07 13:00 +0200
        Re: [PATCH 1/4] ARM: multi_v7_defconfig: Enable common Rockchip  devices/busses Javier Martinez Canillas <javier@osg.samsung.com> - 2015-09-07 13:10 +0200

csiph-web