Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1217918
| From | Doug Anderson <dianders@chromium.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 1/2] ARM: dts: rockchip: pull up cts lines on rk3288 |
| Date | 2015-09-03 01:40 +0200 |
| Message-ID | <q4pNf-32i-1@gated-at.bofh.it> (permalink) |
| References | <q4pDz-2R2-5@gated-at.bofh.it> <q4pDz-2R2-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Alex, On Wed, Sep 2, 2015 at 4:27 PM, Alexandru M Stan <amstan@chromium.org> wrote: > The flow control lines from a user accessible UART are optional, > the user might not have anything connected to those pins. > In order to prevent random interrupts happening and noise affecting > the cts pin should be pulled up. > > Note that the default state for that pin on the rk3288 is pulled up, > so this patch merely restores them. > > This is similar to what we're already doing with the RX pin, > so it should be safe. At worst it might be a slightly higher power usage > (through ~50 kohms) when the cts is low. > > Suggested-by: Neil Hendin <nhendin@chromium.org> > Signed-off-by: Alexandru M Stan <amstan@chromium.org> > --- > Changes in v2: None Probably not entirely true. ;) > arch/arm/boot/dts/rk3288.dtsi | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Looks good to me. Reviewed-by: Douglas Anderson <dianders@chromium.org> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 0/2] ARM: dts: rockchip: pull up cts lines Alexandru M Stan <amstan@chromium.org> - 2015-09-03 01:30 +0200
[PATCH v2 1/2] ARM: dts: rockchip: pull up cts lines on rk3288 Alexandru M Stan <amstan@chromium.org> - 2015-09-03 01:30 +0200
Re: [PATCH v2 1/2] ARM: dts: rockchip: pull up cts lines on rk3288 Doug Anderson <dianders@chromium.org> - 2015-09-03 01:40 +0200
Re: [PATCH v2 0/2] ARM: dts: rockchip: pull up cts lines Heiko Stuebner <heiko@sntech.de> - 2015-09-03 21:10 +0200
csiph-web