Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1219005

Re: [PATCH] ethernet: synopsys: SYNOPSYS_DWC_ETH_QOS should depend on HAS_DMA

From Lars Persson <lars.persson@axis.com>
Newsgroups linux.kernel
Subject Re: [PATCH] ethernet: synopsys: SYNOPSYS_DWC_ETH_QOS should depend on HAS_DMA
Date 2015-09-04 15:40 +0200
Message-ID <q4ZnL-3wF-87@gated-at.bofh.it> (permalink)
References <q4YBk-2kr-25@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, 2015-09-04 at 14:44 +0200, Geert Uytterhoeven wrote:
> If NO_DMA=y:
> 
>     ERROR: "dma_alloc_coherent" [drivers/net/ethernet/synopsys/dwc_eth_qos.ko] undefined!
>     ERROR: "dma_free_coherent" [drivers/net/ethernet/synopsys/dwc_eth_qos.ko] undefined!
>     ERROR: "dma_unmap_single" [drivers/net/ethernet/synopsys/dwc_eth_qos.ko] undefined!
>     ERROR: "dma_map_page" [drivers/net/ethernet/synopsys/dwc_eth_qos.ko] undefined!
>     ERROR: "dma_mapping_error" [drivers/net/ethernet/synopsys/dwc_eth_qos.ko] undefined!
>     ERROR: "dma_map_single" [drivers/net/ethernet/synopsys/dwc_eth_qos.ko] undefined!
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Acked-by: Lars Persson <larper@axis.com>

> ---
>  drivers/net/ethernet/synopsys/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/synopsys/Kconfig b/drivers/net/ethernet/synopsys/Kconfig
> index a8f315106742d9b1..8276ee5a7d541b2e 100644
> --- a/drivers/net/ethernet/synopsys/Kconfig
> +++ b/drivers/net/ethernet/synopsys/Kconfig
> @@ -20,7 +20,7 @@ config SYNOPSYS_DWC_ETH_QOS
>  	select PHYLIB
>  	select CRC32
>  	select MII
> -	depends on OF
> +	depends on OF && HAS_DMA
>  	---help---
>  	  This driver supports the DWC Ethernet QoS from Synopsys
>  



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] ethernet: synopsys: SYNOPSYS_DWC_ETH_QOS should depend on HAS_DMA Geert Uytterhoeven <geert@linux-m68k.org> - 2015-09-04 14:50 +0200
  Re: [PATCH] ethernet: synopsys: SYNOPSYS_DWC_ETH_QOS should depend  on HAS_DMA Lars Persson <lars.persson@axis.com> - 2015-09-04 15:40 +0200
  Re: [PATCH] ethernet: synopsys: SYNOPSYS_DWC_ETH_QOS should depend  on HAS_DMA David Miller <davem@davemloft.net> - 2015-09-07 04:50 +0200

csiph-web