Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1216015

Re: [PATCH v3] selftests/zram: Adding zram tests

Show all headers | View raw

On Tue, 2015-08-18 at 12:31 +0530, naresh.kamboju@linaro.org wrote:
> From: Naresh Kamboju <naresh.kamboju@linaro.org>
> 
> diff --git a/tools/testing/selftests/zram/Makefile b/tools/testing/selftests/zram/Makefile
> new file mode 100644
> index 0000000..ec45513
> --- /dev/null
> +++ b/tools/testing/selftests/zram/Makefile
> @@ -0,0 +1,12 @@
> +all:
> +
> +TEST_PROGS := zram.sh
> +TEST_FILES := zram01.sh zram02.sh zram_lib.sh
> +
> +include ../lib.mk
> +
> +run_tests:
> +	@/bin/bash ./zram.sh
> +

This is wrong, it gives me:

$ make TARGETS=zram install
...
Makefile:9: warning: overriding recipe for target 'run_tests'
../lib.mk:12: warning: ignoring old recipe for target 'run_tests'


If you want to define run_tests you need to do:

override define RUN_TESTS
	./zram.sh
endef


BUT, I don't see any reason why you need to override run_tests. The default
rule will just run TEST_PROGS, which is zram.sh so that should work fine?

cheers


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3] selftests/zram: Adding zram tests Michael Ellerman <mpe@ellerman.id.au> - 2015-08-31 06:10 +0200
  Re: [PATCH v3] selftests/zram: Adding zram tests Naresh Kamboju <naresh.kamboju@linaro.org> - 2015-08-31 14:20 +0200

csiph-web