Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1216537

Re: [GIT PULL] Early batch of KVM changes for 4.3 merge window

Show all headers | View raw

Hmm:

On Fri, Aug 14, 2015 at 4:57 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> Xiao Guangrong (9):
>       KVM: MMU: fully check zero bits for sptes

The above commit causes an annoying new compiler warning.

The warning is bogus ("variable 'leaf' possibly uninitialized"),
because the use of the variable is protected by the 'bool reserved'
flag, but gcc is apparently not smart enough to understand that.

Since bogus warnings cause people to possibly ignore the *real*
warnings, this should be fixed. Maybe the code should get rid of that
'reserved' flag, and instead initialize "leaf" to zero, and use that
as the flag instead (since zero isn't a valid level)? That would
actually avoid an extra variable, and would get rid of the warning.

Hmm?

                 Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [GIT PULL] Early batch of KVM changes for 4.3 merge window Linus Torvalds <torvalds@linux-foundation.org> - 2015-09-01 02:50 +0200
  Re: [GIT PULL] Early batch of KVM changes for 4.3 merge window Xiao Guangrong <guangrong.xiao@linux.intel.com> - 2015-09-01 08:00 +0200
    Re: [GIT PULL] Early batch of KVM changes for 4.3 merge window Paolo Bonzini <pbonzini@redhat.com> - 2015-09-01 19:10 +0200
  Re: [GIT PULL] Early batch of KVM changes for 4.3 merge window Paolo Bonzini <pbonzini@redhat.com> - 2015-09-01 19:10 +0200
    Re: [GIT PULL] Early batch of KVM changes for 4.3 merge window Xiao Guangrong <guangrong.xiao@linux.intel.com> - 2015-09-02 00:50 +0200

csiph-web