Re: [PATCH V4 2/2] PM / OPP: Fix static checker warning (broken 64bit big endian systems)

From	"Rafael J. Wysocki" <rjw@rjwysocki.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH V4 2/2] PM / OPP: Fix static checker warning (broken 64bit big endian systems)
Date	2015-08-28 15:50 +0200
Message-ID	<q2scA-4SC-25@gated-at.bofh.it> (permalink)
References	<pWC4V-2z5-1@gated-at.bofh.it> <pYt7c-Gw-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Monday, August 17, 2015 07:20:20 PM Viresh Kumar wrote:
> Dan Carpenter reported (generated with static checker):
> 
> drivers/base/power/opp.c:949 _opp_add_static_v2()
> warn: passing casted pointer '&new_opp->clock_latency_ns' to
> 'of_property_read_u32()' 64 vs 32.
> 
> This code will break on 64 bit, big endian machines.
> 
> Fix this by reading the value in a u32 type variable first and then
> assigning it to the unsigned long variable.
> 
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Suggested-by: Stephen Boyd <sboyd@codeaurora.org>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

I've applied this and the [1/2], thanks!

Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH V4 2/2] PM / OPP: Fix static checker warning (broken 64bit big endian systems) "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-08-28 15:50 +0200

csiph-web