Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1215019

Re: [RESEND PATCH v16 4/4] ARM: dts: add the support power-domain node on RK3288 SoCs

Show all headers | View raw

Dmitry Torokhov <dmitry.torokhov@gmail.com> writes:

> On Tue, Aug 25, 2015 at 3:45 PM, Kevin Hilman <khilman@kernel.org> wrote:
>> Doug Anderson <dianders@chromium.org> writes:
>>
>>> To put things in a
>>> concrete way, for pd_vio we'd go through the entire device tree
>>> ourselves and find all properties that look like "power-domains =
>>> <&power RK3288_PD_VIO>;".  We'd then find the parent of those
>>> properties and look for a property named "clocks".  We'd then iterate
>>> over all those clocks and turn those on.  Did I get that right?
>>
>> ... but you make it sound like more work than it is.  The genpd already
>> keeps a list of devices that refer to the power domain.  In fact, the
>> genpd 'attach' method can be platform-specific, so could be used to keep
>> track of a list (or a subset) of clocks which are needed for reset.
>
> That is not really workable: the attach and detach happen in
> probe/remove path; if you do not have driver for the device you will
> miss the clocks for it. 

And in my proposal, I suggested that clocks without drivers are
good candidates to list in the domain, with the caveat that the be
called out (documented) as being device clocks that are missing a
driver, so when a driver shows up they can be moved accordingly, and in
a way that actually describes the hardware.

> And the quirk of this SoC is that we need to
> turn all clocks during domain transition, regardless of whether there
> is a driver for all devices.

I understand.  And that "quirk" is not unique to rockchip socs.

Kevin




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RESEND PATCH v16 0/4] ARM: rk3288: Add PM Domain support Caesar Wang <wxt@rock-chips.com> - 2015-08-25 09:30 +0200
  [RESEND PATCH v16 1/4] dt-bindings: add document of Rockchip power domain Caesar Wang <wxt@rock-chips.com> - 2015-08-25 09:30 +0200
  [RESEND PATCH v16 2/4] ARM: power-domain: rockchip: add all the domain type on RK3288 SoCs Caesar Wang <wxt@rock-chips.com> - 2015-08-25 09:30 +0200
  [RESEND PATCH v16 4/4] ARM: dts: add the support power-domain node on RK3288 SoCs Caesar Wang <wxt@rock-chips.com> - 2015-08-25 09:40 +0200
    Re: [RESEND PATCH v16 4/4] ARM: dts: add the support power-domain node on RK3288 SoCs Kevin Hilman <khilman@kernel.org> - 2015-08-25 23:10 +0200
      Re: [RESEND PATCH v16 4/4] ARM: dts: add the support power-domain  node on RK3288 SoCs Doug Anderson <dianders@chromium.org> - 2015-08-25 23:50 +0200
        Re: [RESEND PATCH v16 4/4] ARM: dts: add the support power-domain node on RK3288 SoCs Kevin Hilman <khilman@kernel.org> - 2015-08-26 00:50 +0200
          Re: [RESEND PATCH v16 4/4] ARM: dts: add the support power-domain  node on RK3288 SoCs Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-08-26 01:50 +0200
            Re: [RESEND PATCH v16 4/4] ARM: dts: add the support power-domain node on RK3288 SoCs Kevin Hilman <khilman@kernel.org> - 2015-08-28 02:30 +0200
              Re: [RESEND PATCH v16 4/4] ARM: dts: add the support power-domain  node on RK3288 SoCs Doug Anderson <dianders@chromium.org> - 2015-08-28 04:10 +0200
                Re: [RESEND PATCH v16 4/4] ARM: dts: add the support power-domain node on  RK3288 SoCs Michael Turquette <mturquette@linaro.org> - 2015-08-28 22:10 +0200
                Re: [RESEND PATCH v16 4/4] ARM: dts: add the support power-domain  node on RK3288 SoCs Doug Anderson <dianders@chromium.org> - 2015-08-28 23:10 +0200
                Re: [RESEND PATCH v16 4/4] ARM: dts: add the support power-domain node on  RK3288 SoCs Michael Turquette <mturquette@baylibre.com> - 2015-08-29 01:00 +0200
                Re: [RESEND PATCH v16 4/4] ARM: dts: add the support power-domain node on RK3288 SoCs Kevin Hilman <khilman@kernel.org> - 2015-08-28 23:30 +0200
          Re: [RESEND PATCH v16 4/4] ARM: dts: add the support power-domain  node on RK3288 SoCs Doug Anderson <dianders@chromium.org> - 2015-08-26 02:00 +0200
          Re: [RESEND PATCH v16 4/4] ARM: dts: add the support power-domain  node on RK3288 SoCs Caesar Wang <wxt@rock-chips.com> - 2015-08-26 11:30 +0200

csiph-web