Re: [PATCH] cred: Remove unnecessary kdebug atomic reads

From	David Howells <dhowells@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] cred: Remove unnecessary kdebug atomic reads
Date	2015-08-26 01:40 +0200
Message-ID	<q1vYR-50b-11@gated-at.bofh.it> (permalink)
References	<q1taF-He-7@gated-at.bofh.it> <q1pJL-3ZR-7@gated-at.bofh.it> <q1taF-He-7@gated-at.bofh.it>
Organization	Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Show all headers | View raw

Andrew Morton <akpm@linux-foundation.org> wrote:

> Did you consider doing this within no_printk()?  That would break code
> which is relying on side-effects in the evaluation of a printk arg but
> that's pretty weird and I bet there isn't (and won't be) such code.

The reasons that no_printk() is like it is are (1) so that the side-effects
stay intact and (2) you still get format warnings.  If someone prints a device
register, for example, it *must* work the same whether or not you use printk()
or no_printk().  Of course, printing a device register like this is probably
not a good idea...

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] cred: Remove unnecessary kdebug atomic reads Joe Perches <joe@perches.com> - 2015-08-25 19:00 +0200
  Re: [PATCH] cred: Remove unnecessary kdebug atomic reads Andrew Morton <akpm@linux-foundation.org> - 2015-08-25 22:40 +0200
    Re: [PATCH] cred: Remove unnecessary kdebug atomic reads Andrew Morton <akpm@linux-foundation.org> - 2015-08-25 23:00 +0200
      Re: [PATCH] cred: Remove unnecessary kdebug atomic reads Joe Perches <joe@perches.com> - 2015-08-25 23:20 +0200
    Re: [PATCH] cred: Remove unnecessary kdebug atomic reads Joe Perches <joe@perches.com> - 2015-08-25 23:00 +0200
    Re: [PATCH] cred: Remove unnecessary kdebug atomic reads David Howells <dhowells@redhat.com> - 2015-08-26 01:40 +0200

csiph-web