Re: [PATCH v10 1/5] mtd: nand: vf610_nfc: Freescale NFC for VF610, MPC5125 and others

From	Brian Norris <computersforpeace@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v10 1/5] mtd: nand: vf610_nfc: Freescale NFC for VF610, MPC5125 and others
Date	2015-08-25 22:40 +0200
Message-ID	<q1taH-He-35@gated-at.bofh.it> (permalink)
References	<pTked-7lf-3@gated-at.bofh.it> <pTkee-7lf-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

One more thing...

On Mon, Aug 03, 2015 at 11:27:26AM +0200, Stefan Agner wrote:
> --- /dev/null
> +++ b/drivers/mtd/nand/vf610_nfc.c
> @@ -0,0 +1,645 @@
...
> +struct vf610_nfc {
> +	struct mtd_info mtd;
> +	struct nand_chip chip;
> +	struct device *dev;
> +	void __iomem *regs;
> +	struct completion cmd_done;
> +	uint buf_offset;
> +	int page_sz;

AFAICT (even with the 2nd patch), you never really use this field. You
just set it/increment it, but don't use it for anything. Kill it?

> +	/* Status and ID are in alternate locations. */
> +	int alt_buf;
> +#define ALT_BUF_ID   1
> +#define ALT_BUF_STAT 2
> +#define ALT_BUF_ONFI 3
> +	struct clk *clk;
> +};

Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v10 1/5] mtd: nand: vf610_nfc: Freescale NFC for VF610,  MPC5125 and others Brian Norris <computersforpeace@gmail.com> - 2015-08-25 22:40 +0200
  Re: [PATCH v10 1/5] mtd: nand: vf610_nfc: Freescale NFC for VF610,  MPC5125 and others Stefan Agner <stefan@agner.ch> - 2015-08-27 03:20 +0200
    Re: [PATCH v10 1/5] mtd: nand: vf610_nfc: Freescale NFC for VF610,  MPC5125 and others Brian Norris <computersforpeace@gmail.com> - 2015-08-27 18:50 +0200

csiph-web