Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1213993

[PATCH 04/22] perf ordered_events: Clear the progress bar at the end of a flush

Show all headers | View raw

From: Arnaldo Carvalho de Melo <acme@redhat.com>

We were depending on the next screen operation after a flush() being
one that would redraw the whole screen so that the progress bar would
be overwritten, when that didn't happen a screen artifact of, say, a
error dialog window would be overlaid on top of the progress bar, fix
it by calling ui_browser__finish(), that now has a TUI implementation.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-el0fyw6duemnx62lydjzhs8c@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/ordered-events.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tools/perf/util/ordered-events.c b/tools/perf/util/ordered-events.c
index 52be201b9b25..b1b9e2385f4b 100644
--- a/tools/perf/util/ordered-events.c
+++ b/tools/perf/util/ordered-events.c
@@ -220,6 +220,9 @@ static int __ordered_events__flush(struct ordered_events *oe)
 	else if (last_ts <= limit)
 		oe->last = list_entry(head->prev, struct ordered_event, list);
 
+	if (show_progress)
+		ui_progress__finish();
+
 	return 0;
 }
 
-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[GIT PULL 00/22] perf/core improvements and fixes Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-08-26 18:00 +0200
  [PATCH 14/22] perf tools: Update Intel PT documentation Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-08-26 18:00 +0200
  [PATCH 09/22] perf tools: Add Intel PT support for decoding MTC packets Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-08-26 18:00 +0200
  [PATCH 21/22] perf probe: Support probing at absolute address Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-08-26 18:00 +0200
  [PATCH 03/22] perf ui tui progress: Implement the ui_progress_ops->finish() method Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-08-26 18:00 +0200
  [PATCH 01/22] perf tools: Fix tarball build broken by pt/bts Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-08-26 18:00 +0200
  [PATCH 05/22] perf tools: Fix Intel PT 'instructions' sample period Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-08-26 18:10 +0200
  [PATCH 16/22] perf tools: Remove export.h from MANIFEST Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-08-26 18:10 +0200
  [PATCH 11/22] perf tools: Add Intel PT support for decoding CYC packets Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-08-26 18:10 +0200
  [PATCH 04/22] perf ordered_events: Clear the progress bar at the end of a flush Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-08-26 18:10 +0200
  [PATCH 08/22] perf tools: Pass Intel PT information for decoding MTC and CYC Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-08-26 18:10 +0200
  [PATCH 06/22] perf tools: Add Intel PT support for PSB periods Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-08-26 18:10 +0200
  [PATCH 19/22] perf probe: Fix list result when address is zero Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-08-26 18:10 +0200
  [PATCH 18/22] perf probe: Fix list result when symbol can't be found Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-08-26 18:10 +0200
  [PATCH 07/22] perf tools: Add new Intel PT packet definitions Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-08-26 18:10 +0200
  [PATCH 15/22] perf probe: Prevent segfault when reading probe point with absolute address Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-08-26 18:10 +0200
  [PATCH 12/22] perf tools: Add Intel PT support for using CYC packets Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-08-26 18:10 +0200
  [PATCH 20/22] perf probe: Fix error reported when offset without function Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-08-26 18:10 +0200
  [PATCH 22/22] tracing/uprobes: Do not print '0x (null)' when offset is 0 Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-08-26 18:10 +0200
  [PATCH 10/22] perf tools: Add Intel PT support for using MTC packets Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-08-26 18:10 +0200
  [PATCH 17/22] tools build: Allow duplicate objects in the object list Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-08-26 18:10 +0200
  [PATCH 13/22] perf tools: Add Intel PT support for decoding TRACESTOP packets Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-08-26 18:10 +0200
  Re: [GIT PULL 00/22] perf/core improvements and fixes Ingo Molnar <mingo@kernel.org> - 2015-08-28 08:30 +0200

csiph-web