Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1213715

Re: [PATCH v3 1/4] irqchip: GICv3: Convert to EOImode == 1

Show all headers | View raw

On 26/08/15 09:54, Eric Auger wrote:
> Hi Marc,
> On 08/25/2015 01:53 PM, Marc Zyngier wrote:
>> So far, GICv3 has been used in with EOImode == 0. The effect of this
>> mode is to perform the priority drop and the deactivation of the
>> interrupt at the same time.
>>
>> While this works perfectly for Linux (we only have a single priority),
>> it causes issues when an interrupt is forwarded to a guest, and when
>> we want the guest to perform the EOI itself.
>>
>> For this case, the GIC architecture provides EOImode == 1, where:
>> - A write to ICC_EOIR1_EL1 drops the priority of the interrupt and
>>   leaves it active. Other interrupts at the same priority level can
>>   now be taken, but the active interrupt cannot be taken again
>> - A write to ICC_DIR_EL1 marks the interrupt as inactive, meaning
>>   it can now be taken again.
>>
>> This patch converts the driver to be able to use this new mode,
>> depending on whether or not the kernel can behave as a hypervisor.
>> No feature change.
>>
>> Reviewed-by: Eric Auger <eric.auger@linaro.org>
>> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
>> ---
>>  drivers/irqchip/irq-gic-v3.c       | 39 ++++++++++++++++++++++++++++++++++----
>>  include/linux/irqchip/arm-gic-v3.h |  9 +++++++++
>>  2 files changed, 44 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
>> index c52f7ba..addd2ee 100644
>> --- a/drivers/irqchip/irq-gic-v3.c
>> +++ b/drivers/irqchip/irq-gic-v3.c
>> @@ -30,6 +30,7 @@
>>  #include <asm/cputype.h>
>>  #include <asm/exception.h>
>>  #include <asm/smp_plat.h>
>> +#include <asm/virt.h>
>>  
>>  #include "irq-gic-common.h"
>>  #include "irqchip.h"
>> @@ -50,6 +51,7 @@ struct gic_chip_data {
>>  };
>>  
>>  static struct gic_chip_data gic_data __read_mostly;
>> +static struct static_key supports_deactivate = STATIC_KEY_INIT_TRUE;
> 
> in http://www.spinics.net/lists/arm-kernel/msg439813.html, Catalin
> reported the direct usage of static_key was deprecated. Sorry I learned
> that after my last review.
> 
> see https://lkml.org/lkml/2015/8/3/539

Hi Eric,

I'm aware of Peter's work to rework static keys, but that code is not
merged yet (though I believe it is on its way to 4.3). I have an
additional patch that repaints the code to use static_key_likely() all
over the place, but I keep it separate for the time being.

If this series makes it in for 4.3, I'll post the repainting patch after
-rc1. Otherwise, I'll just update it in my tree.

I'm about to post v4 anyway, and I'll mention this in the cover letter.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/4] irqchip: GICv2/v3: Add support for irq_vcpu_affinity Marc Zyngier <marc.zyngier@arm.com> - 2015-08-25 14:00 +0200
  [PATCH v3 3/4] irqchip: GIC: Convert to EOImode == 1 Marc Zyngier <marc.zyngier@arm.com> - 2015-08-25 14:00 +0200
    Re: [PATCH v3 3/4] irqchip: GIC: Convert to EOImode == 1 Thomas Gleixner <tglx@linutronix.de> - 2015-08-25 17:50 +0200
      Re: [PATCH v3 3/4] irqchip: GIC: Convert to EOImode == 1 Marc Zyngier <marc.zyngier@arm.com> - 2015-08-25 19:20 +0200
  [PATCH v3 4/4] irqchip: GIC: Don't deactivate interrupts forwarded to a guest Marc Zyngier <marc.zyngier@arm.com> - 2015-08-25 14:00 +0200
  [PATCH v3 1/4] irqchip: GICv3: Convert to EOImode == 1 Marc Zyngier <marc.zyngier@arm.com> - 2015-08-25 14:00 +0200
    Re: [PATCH v3 1/4] irqchip: GICv3: Convert to EOImode == 1 Eric Auger <eric.auger@linaro.org> - 2015-08-26 11:00 +0200
      Re: [PATCH v3 1/4] irqchip: GICv3: Convert to EOImode == 1 Marc Zyngier <marc.zyngier@arm.com> - 2015-08-26 12:20 +0200
  [PATCH v3 2/4] irqchip: GICv3: Don't deactivate interrupts forwarded to a guest Marc Zyngier <marc.zyngier@arm.com> - 2015-08-25 14:00 +0200

csiph-web