Groups > linux.kernel > #1161907

Re: [PATCH] usb: dwc2: fix unnecessary USB overcurrent condition

From	John Youn <John.Youn@synopsys.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] usb: dwc2: fix unnecessary USB overcurrent condition
Date	2015-06-10 04:20 +0200
Message-ID	<pzDMu-re-1@gated-at.bofh.it> (permalink)
References	<pzDMu-re-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Dinh,

Responding again to the proper message to add linux-usb. And also
added more comments.

On 5/26/2015 7:32 PM, dinguyen@opensource.altera.com wrote:
> From: Dinh Nguyen <dinguyen@opensource.altera.com>
> 
> For platforms that use a ULPI phy, we should enable the external VbusValid
> signal instead.

I don't think it should be for all ULPI phys. Though I'm not that
familiar with ULPI.

> 
> Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
> Cc: Gregory Herrero <gregory.herrero@intel.com>
> Cc: Mian Yousaf Kaukab <yousaf.kaukab@intel.com>
> Cc: Felipe Balbi <balbi@ti.com>
> ---
>  drivers/usb/dwc2/core.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/usb/dwc2/core.c b/drivers/usb/dwc2/core.c
> index e5b546f..08ffdc6 100644
> --- a/drivers/usb/dwc2/core.c
> +++ b/drivers/usb/dwc2/core.c
> @@ -807,6 +807,11 @@ int dwc2_core_init(struct dwc2_hsotg *hsotg, bool select_phy, int irq)
>  	if (hsotg->core_params->ts_dline > 0)
>  		usbcfg |= GUSBCFG_TERMSELDLPULSE;
>  
> +	/* Set external VBUS indicator as needed. */
> +	if (hsotg->core_params->phy_type == DWC2_PHY_TYPE_PARAM_ULPI)
> +		usbcfg |= (GUSBCFG_ULPI_INT_VBUS_IND |
> +			   GUSBCFG_INDICATORPASSTHROUGH);
> +

I think these should all be conditional on using the external
vbus, and probably also on the features themselves since it will
depend on the PHY and platform how you want to set these bits.

John

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] usb: dwc2: fix unnecessary USB overcurrent condition John Youn <John.Youn@synopsys.com> - 2015-06-10 04:20 +0200

csiph-web