Re: [PATCH] mfd: cros_ec: Fix possible leak in led_rgb_store()

From	Olof Johansson <olof@lixom.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mfd: cros_ec: Fix possible leak in led_rgb_store()
Date	2015-08-21 19:20 +0200
Message-ID	<pZY8W-1FW-9@gated-at.bofh.it> (permalink)
References	<pO2L0-3Yv-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Jul 19, 2015 at 09:43:02PM +0200, Christian Engelmayer wrote:
> Function led_rgb_store() contains some direct returns in error cases that
> leak the already allocated cros_ec_command message structure. Make sure
> that 'msg' is freed in all exit paths. Detected by Coverity CID 1309666.
> 
> Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
> ---
> Compile tested only. Applies against linux-next.

Applied with adjusted patch subject.


-Olof

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] mfd: cros_ec: Fix possible leak in led_rgb_store() Olof Johansson <olof@lixom.net> - 2015-08-21 19:20 +0200

csiph-web