Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1211257

Re: [PATCHv2] Input: xpad - Fix double URB submission races

From Dmitry Torokhov <dmitry.torokhov@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCHv2] Input: xpad - Fix double URB submission races
Date 2015-08-21 19:00 +0200
Message-ID <pZXPB-14O-27@gated-at.bofh.it> (permalink)
References <pW5C3-5yL-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi Laura,

On Mon, Aug 10, 2015 at 05:26:12PM -0700, Laura Abbott wrote:
> v2: Created a proper queue for events instead of just dropping them

How long does it take for the queue to exhaust your memory if you keep
bombarding the driver with requests?

I do not think you need a queue. I believe the nature of LEDs and rumble
force feedback effect is such that you can discard all requests but the
latest that arrived between the moment you submitted a request to the
device and the moment you are ready submit a new one.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

Re: [PATCHv2] Input: xpad - Fix double URB submission races Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-08-21 19:00 +0200
  Re: [PATCHv2] Input: xpad - Fix double URB submission races Laura Abbott <labbott@redhat.com> - 2015-08-25 06:30 +0200
    Re: [PATCHv2] Input: xpad - Fix double URB submission races Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-08-26 19:20 +0200

csiph-web